-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate System Framework #146
Conversation
f0024e6
to
c042948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the files should have an empty end line.
snake_case should be used everywhere
please look at the other files and format it accordingly
include/boost/astronomy/coordinate/coord_sys/equatorial_coord.hpp
Outdated
Show resolved
Hide resolved
include/boost/astronomy/coordinate/coord_sys/equatorial_coord.hpp
Outdated
Show resolved
Hide resolved
@lpranam If yes then I'll make this PR Ready for Review and you can review it and give approval. I'll complete Concept Checking and then you can merge both the PR's.
|
include/boost/astronomy/coordinate/coord_sys/equatorial_coord.hpp
Outdated
Show resolved
Hide resolved
include/boost/astronomy/coordinate/coord_sys/equatorial_coord.hpp
Outdated
Show resolved
Hide resolved
include/boost/astronomy/coordinate/coord_sys/ecliptic_coord.hpp
Outdated
Show resolved
Hide resolved
include/boost/astronomy/coordinate/coord_sys/galactic_coord.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete equatorial_coord.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work keep it up.
The Coordinate System Framework
To fix the position of any astronomical object, this coordinate system framework provides tools to assign a different pair of numbers to every point in the sky.
Each system takes its name from the fundamental plane which it uses as a reference
This framework contains
Base class coord_sys
and the four Coordinate System
1. Equatorial Coordinate System equatorial_coord.hpp
2. Horizon Coordinate System horizon_coord.hpp
3. Ecliptic Coordinate System ecliptic_coord.hpp
4. Galactic Coordinate System galactic_coord.hpp