Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate System Framework #146

Merged
merged 49 commits into from
Jul 12, 2020
Merged

Coordinate System Framework #146

merged 49 commits into from
Jul 12, 2020

Conversation

Zyro9922
Copy link
Member

@Zyro9922 Zyro9922 commented May 17, 2020

The Coordinate System Framework

To fix the position of any astronomical object, this coordinate system framework provides tools to assign a different pair of numbers to every point in the sky.

Each system takes its name from the fundamental plane which it uses as a reference

This framework contains

Base class coord_sys

and the four Coordinate System

1. Equatorial Coordinate System equatorial_coord.hpp
2. Horizon Coordinate System horizon_coord.hpp
3. Ecliptic Coordinate System ecliptic_coord.hpp
4. Galactic Coordinate System galactic_coord.hpp

@Zyro9922 Zyro9922 changed the title Created Coord_Sys and Horizon_Coord Coordinate System Framework May 17, 2020
@Zyro9922 Zyro9922 marked this pull request as draft May 23, 2020 15:04
@Zyro9922 Zyro9922 force-pushed the develop branch 3 times, most recently from f0024e6 to c042948 Compare May 27, 2020 04:17
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the files should have an empty end line.
snake_case should be used everywhere
please look at the other files and format it accordingly

@Zyro9922
Copy link
Member Author

Zyro9922 commented Jun 7, 2020

@lpranam
The framework is complete and respective tests has been created.
Regarding checks do you want me to use Concepts?

If yes then I'll make this PR Ready for Review and you can review it and give approval.
For concept checking classes I'll open a new Issue and PR.

I'll complete Concept Checking and then you can merge both the PR's.

  • Waiting for @lpranam approval of Coordinate System Framework and Tests.

@Zyro9922 Zyro9922 requested a review from lpranam June 7, 2020 05:56
test/coordinate/Jamfile Outdated Show resolved Hide resolved
test/coordinate/equatorial_coord.cpp Outdated Show resolved Hide resolved
test/coordinate/equatorial_coord.cpp Outdated Show resolved Hide resolved
test/coordinate/equatorial_coord.cpp Outdated Show resolved Hide resolved
@Zyro9922 Zyro9922 marked this pull request as ready for review June 13, 2020 07:33
@Zyro9922 Zyro9922 marked this pull request as draft June 13, 2020 10:57
@Zyro9922 Zyro9922 marked this pull request as ready for review June 24, 2020 11:17
@Zyro9922 Zyro9922 requested a review from lpranam June 24, 2020 11:20
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete equatorial_coord.hpp

Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work keep it up.

@lpranam lpranam merged commit 8caea42 into BoostGSoC19:develop Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants