Merge updated binary puzzle, proof editor, puzzle editor, home panel, bug fixes #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't doing anything and was always returning true.
Fixed buggy three adjacent contradiction rule
# Conflicts: # src/main/java/edu/rpi/legup/puzzle/binary/rules/SurroundPairDirectRule.java # src/main/java/edu/rpi/legup/puzzle/binary/rules/ThreeAdjacentContradictionRule.java
Fake tests added
Fake tests was bad
Basic Last Number for Cell test case.
Implemented 2 new test cases for LastNumberForCell and made Class and Test Case for RepeatedNumber contradiction rule
Added another test for RepeatedNumbers contradiction rule and fixed previous error.
… updated wiki with new rule images
Added final rule images, adjusted naming conventions for rule images,…
added noncode final commit components
…ns in all classes in history directory
…ns in all classes in model directory
…ns in all classes in gameboard directory
…ns in all classes in observer directory
…ns in all classes in model/rules directory
…ns in all classes in model/tree directory
…ns in all classes in model directory
…ns in all classes in ui/boardview directory
…ns in all classes in ui/proofeditor/ruleview directory
…ctly into HomePanel
…ns in all classes in ui/proofeditor/treeview directory
…ns in all classes in ui directory
This reverts commit c274436.
zacharybonagura
commented
Aug 19, 2024
Chase-Grajeda
approved these changes
Aug 30, 2024
|
I'm going to try merging these commits into the dev branch. |
This was referenced Sep 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge updated binary puzzle, including new rules, images, functionality.
New look and functionality for proof editor.
New look and functionality for puzzle editor.
Revised home panel.
Many bug fixes throughout the engine