Minesweeper #875
Merged
Minesweeper #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made it so the user cannot change number and can only change whether or not there exists a bomb on a square.
I had to switch DATA_ATTRIBUTE from data to value in order for the board to actually load
I added values for the cells in the minesweeper puzzle for testing
Some fixes to less bombs than flag and more bombs than flag contradiction rule. Also fixes to stuff using thar rule. New minesweeper boards as well.
Another minesweeper board
Sort of working version of minesweeper. Probably has bugs but I have not found them yet. Also not completely done because I still have to change the images of the direct rules.
Fixed bugs in direct rule, cleaned up code and fixed other bugs, added 3 more 7x7 easy minesweeper boards
Beginning of 1-2-X rule. Works in one case but need to add mirror and rotations. Other bug fixes and improvements.
1-2-X case rule should now be working in all horizontal cases. I wanted to use a loop to check all cases but that seems less efficient
1-2-X rule done in all cases hopefully (i tested it a lot I hope its good). Also new board and bug fixes.
Added 1-1-E direct rule. Also updated some stuff in 1-2-X direct rules and other files.
Added images for all of the direct rules. Added new minesweeper boards. Other small fixes and improvements.
A bunch of test cases for Must Contain Bomb Direct Rule
Added test cases for must not contain bomb direct rule
New images for all of the minesweeper rules
changed a ton of stuff to use more consistent wording (such as saying mine instead of bomb) and also commented some code that needed comments
title. also a couple other tiny improvements
Created the test suites for both of the case rules. Also some minor changes
Test suites for both of the contradiction rules
Update Minesweeper Branch
delete files
more bug fixes
some small improvements and comments
New rule isolatemine - a mine must see a number cell. Added the rule and test suite for the rule.
Minesweeper changes
|
There are some inconsistencies with file naming convention, but we can clean that up at a later point in time. For now, I'm going to merge these changes into dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation merge from #871
Description
Completing the implementation of the Minesweeper puzzle type:
Type of change
How Has This Been Tested?
All of the rules have test suites so they should work. I had other people play minesweeper and ran into no issues with the rules or anything else.
Checklist: