CAPI-571 Fix SolrJ Bind Nested Child DTO Fields #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current solrj Document DTO to SolrInputDocument binder treat all child docs as anonymous rather than prefix them with the given path. This will result in the document being indexed without the `_nest_path_` field populated which is required for the ChildDocumentTransformer (`fl=[child]`) to work. Add a new property to `@Field` interface to determine if a `Field` annoted with `child=true` should be treated as anonymous field or if it should be treated as a nested child document. Where they should be nested child docs, each nested object would be converted to its own `SolrInputDocument` and added as a regular field to the parent `SolrInputDocument`. Having it as a regular field with nested objects will result in Solr indexing these child docs correctly, and it will populate appropriate nested child docs fields during index time. We can now have more that one child documents fields listed in the DTO until they are set and `anonymizeChild=false`.
yfernando-bw
force-pushed
the
CAPI-571-fix-bind-nested-child-dto-fields
branch
from
9481840 to
9f91ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solrj Document DTO to SolrInputDocument binder treat all child docs as anonymous rather than prefix them with the given path. This will result in the document being indexed without the
_nest_path_field populated which is required for the ChildDocumentTransformer (fl=[child]) to work.Add a new property to
@Fieldinterface to determine if aFieldannoted withchild=trueshould be treated as anonymous field or if it should be treated as a nested child document. Where they should be nested child docs, each nested object would be converted to its ownSolrInputDocumentand added as a regular field to the parentSolrInputDocument.Having it as a regular field with nested objects will result in Solr indexing these child docs correctly, and it will populate appropriate nested child docs fields during index time. We can now have more that one child documents fields listed in the DTO until they are set and
anonymizeChild=false.