fix: NSObject offset size in SRObject being too small #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for this library, it have made mixing Rust and Swift a breeze!
However, I encountered a bug when I tried to implement a function which returned a class with 4 ints. The first member of the class always got the same weird number. It seems like the memory offset used in SRObject is not big enough, only taking up one byte whereas a pointer (on 64-bit systems) is 8 bytes.
Replacing the
u8
offset with*const c_void
seems to solve this issue as Rust now allocates the size for a pointer instead of just a byte. The test I also added replicates my issue and fails with theu8
type but passes after the change 🙂