Track usage #15772
Merged
Track usage #15772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
BUDI-9127/track-usage
branch
from
5e3b150 to
cb88465
Compare
Base automatically changed from
BUDI-9127/support-header-and-body-method
to
master
March 19, 2025 18:00
| @@ -28,7 +28,7 @@ function oAuth2ConfigValidator() { | |||
| function oAuth2ConfigValidationValidator() { | |||
| return middleware.joiValidator.body( | |||
| Joi.object({ | |||
| id: Joi.string().required(), | |||
| id: Joi.string(), | |||
There was a problem hiding this comment.
Why is a separate id needed when the config has a _id? Is there multiple OAuth configs within the single oauth document?
There was a problem hiding this comment.
This might validate existing configs or new configs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Track oauth usages. We will update that usage every time that we get an oauth2 token.
The last usage will be picked from the most recent between dev and prod, as we want to track its usage, regarding if used in prod or dev
Screenshots