Add accordion component #15779
Draft
Add accordion component #15779
+88
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…di-9129-convert-accordion-plugin-to-native-component
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
aptkingston
reviewed
Mar 31, 2025
There was a problem hiding this comment.
Nice work Andy! Works perfectly 👌
Just a few small finishing touches I think we could put on it. Looking at the default state when adding a new instance:
I think we could:
- Give it a default title (e.g. just "Accordion")
- Make sure it doesn't say
undefinedwhen there's no text (I've commented in the code how to do this) - Increase the size a bit when added to grid layouts (I would go for the same as a container, so width 500 and height 200 in the
sizekey in the manifest) - Since it's basically a container, I think you always want to grid sizing to be "stretch", which also cleans up the settings bar. So I think we should set both
hAlignandvAligntostretchin the manifest
| export let label | ||
| </script> | ||
|
|
||
| <Accordion header={label} {bold} {initialOpen}> |
There was a problem hiding this comment.
We should change this to header={label || ""} just to ensure it doesn't say undefined when there's no text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new collapsible accordion component to Budibase. Child components show and hide when clicking the header.
Screenshots
If a UI facing feature, a short video of the happy path, and some screenshots of the new functionality.
Launchcontrol
Add accordion component to Budibase
Feature branch env
Feature Branch Link