-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Version Of BeamOFT and BeamOFTAdapter Bridge Build #2
Open
fabriziogianni7
wants to merge
26
commits into
main
Choose a base branch
from
adding-additional-feats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mOFTPermit contract inheriting also from ERC20Permit
…FT and OFTAdapter
fabriziogianni7
changed the title
Final Version Of OFT and OFT adapter Bridge Build
Final Version Of BeamOFT and BeamOFTAdapter Bridge Build
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, there is the final version of OFT and OFTAdapter contracts, needed to deploy layerzero v2 contracts with a low effort.
Help To The Hero Reviewing This
Important to review:
Contracts
Deploy Scripts
Deploy scripts are important and can hide some security issue. have a review to DeployBeamOFT.sol and DeployBeamOFTAdapter.sol
Tests
Have a look to BeamBridgeTest to see how the tests are made and if they make sense
Custom Fees Calculation
I would like to bring the attention of the reviewer to
BeamOFT::_debit
,BeamOFT::_debitView
,BeamOFTAdapter::_debit
,BeamOFTAdapter::_debitView
since it can hide some bug in the fee calculation. Please, check the tests to validate the fee calculationRun Tests
to run test:
forge test
Coverage
to run test coverage:
current coverage is 100% 🧨🧨🧨:
Other Stuff
cli
. check this post for the tutorialSome example transaction
sending LINK back and forth from sepolia to beam