Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[gen1][core] ENG-7507 added class field apiEndpoint$ #3748

Merged
merged 19 commits into from
Dec 10, 2024

Conversation

clyde-builderio
Copy link
Contributor

@clyde-builderio clyde-builderio commented Nov 19, 2024

Description

API Endpoint should be set at the class level and not at the options level

Jira ticket
https://builder-io.atlassian.net/browse/ENG-7507

Loom
https://www.loom.com/share/ffe8bd20e576420f89606a62387f05f5

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 6a22ec2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/sdk Major
@builder.io/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Nov 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6a22ec2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@clyde-builderio clyde-builderio merged commit 56f9461 into BuilderIO:main Dec 10, 2024
47 of 48 checks passed
sidmohanty11 pushed a commit to sidmohanty11/builder that referenced this pull request Dec 19, 2024
## Description

API Endpoint should be set at the class level and not at the options
level

**Jira ticket**
https://builder-io.atlassian.net/browse/ENG-7507

**Loom**
https://www.loom.com/share/ffe8bd20e576420f89606a62387f05f5

---------

Co-authored-by: Clyde Mendonca <[email protected]>
Co-authored-by: Sami Jaber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants