Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-159: Remix Gen1 - Advanced child sub components #3750

Merged
merged 11 commits into from
Dec 9, 2024
Merged

EDU-159: Remix Gen1 - Advanced child sub components #3750

merged 11 commits into from
Dec 9, 2024

Conversation

uttej-vsk
Copy link
Contributor

Description

This PR introduces remix gen 1 example for Advanced child sub-components in the custom components page in the docs.

ticket: https://builder-io.atlassian.net/browse/EDU-324
@samijaber Please review

@uttej-vsk uttej-vsk marked this pull request as ready for review November 19, 2024 17:47
@uttej-vsk uttej-vsk requested review from mrkoreye and removed request for a team November 19, 2024 17:47
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7bdc485

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7bdc485. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx test @e2e/gen1-next
nx test @e2e/react-sdk-next-pages
✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

samijaber
samijaber approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove that one unnecessary field

packages/sdks/snippets/gen1-remix/app/routes/advanced-child.tsx Outdated Show resolved Hide resolved
@uttej-vsk uttej-vsk merged commit bdea15d into BuilderIO:main Dec 9, 2024
43 of 48 checks passed
sidmohanty11 pushed a commit to sidmohanty11/builder that referenced this pull request Dec 19, 2024
@uttej-vsk @sidmohanty11
EDU-159: Remix Gen1 - Advanced child sub components (BuilderIO#3750)
b21b288 
## Description

This PR introduces remix gen 1 example for Advanced child sub-components
in the custom components page in the docs.

ticket: https://builder-io.atlassian.net/browse/EDU-324
@samijaber Please review

---------

Authored-by: Uttej Venkata Sastry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samijaber samijaber samijaber approved these changes

@kapunahelewong kapunahelewong Awaiting requested review from kapunahelewong

@mrkoreye mrkoreye Awaiting requested review from mrkoreye mrkoreye was automatically assigned from BuilderIO/packages

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uttej-vsk @samijaber