Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks #3993

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

uttej-vsk
Copy link
Contributor

@uttej-vsk uttej-vsk commented Mar 27, 2025

Description

This PR belongs to ticket EDU-134 and is similar to the previously raised React PR on the Product details—blueprints ticket 591. But this PR is more about adding all the frameworks as suggested by Sami to maintain one PR for one framework and use the first PR to work on all review comments and the second PR(like this one) to include all the remaining frameworks.

  • Included all the gen 2 frameworks
  • All test cases are passed
  • Removed unwanted imports and styles
  • Reviewed locally before raising PR

Frameworks included:

  • Vue and its test cases passed
  • Nuxt and its test cases passed
  • Svelte
  • Sveltekit
  • Qwik
  • Hydrogen
  • React SDK Next 14 App
  • React SDK Next pages

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 21f0136

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Mar 27, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret 21f0136 packages/sdks/snippets/react-sdk-next-14-app/app/(blueprints-product-details)/products/[handle]/page.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Mar 27, 2025

View your CI Pipeline Execution ↗ for commit 21f0136.

Command Status Duration Result
nx test @snippet/react-sdk-next-pages ❌ Failed 43s View ↗
nx test @e2e/qwik-city ✅ Succeeded 8m 13s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 7m 47s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 28s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 5m 50s View ↗
nx test @e2e/hydrogen ✅ Succeeded 5m 38s View ↗
nx test @e2e/angular-16 ✅ Succeeded 6m 26s View ↗
nx test @e2e/react-sdk-next-pages ✅ Succeeded 5m 13s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 04:42:33 UTC

@uttej-vsk uttej-vsk changed the title EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks WIO - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks Apr 1, 2025
@uttej-vsk uttej-vsk changed the title WIO - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks [WIP] - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant