apply sami’s suggestion

BuilderIO · Nov 21, 2024 · d67920d · d67920d
1 parent 04da1f6
commit d67920d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/packages/core/src/generators/mitosis/generator.ts b/packages/core/src/generators/mitosis/generator.ts
@@ -138,7 +138,7 @@ export const blockToMitosis = (
   for (const key in json.bindings) {
     const value = json.bindings[key]?.code as string;
 
-    if (json.slots?.[key]) {
+    if (!value || json.slots?.[key]) {
       continue;
     }
 

diff --git a/packages/core/src/parsers/builder/builder.ts b/packages/core/src/parsers/builder/builder.ts
@@ -347,15 +347,9 @@ const componentMappers: {
       block.component?.options.columns?.map((col: any, index: number) =>
         createMitosisNode({
           name: 'Column',
-          /**
-           * If width if undefined, do not create a binding otherwise its JSX will
-           * be <Column width={} /> which is not valid due to the empty expression.
-           */
-          ...(col.width !== undefined && {
-            bindings: {
-              width: { code: col.width.toString() },
-            },
-          }),
+          bindings: {
+            width: { code: col.width?.toString() },
+          },
           ...(col.link && {
             properties: {
               link: col.link,