Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor fragment helper in react ot handle keys #1628

Merged
merged 9 commits into from
Nov 8, 2024
Merged

feat: refactor fragment helper in react ot handle keys #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0efd1f3
feat: refactor fragment helper in react ot handle keys
nmerget Nov 5, 2024
85becd5
chore: update snapshots
nmerget Nov 5, 2024
69271ab
Update packages/docs/src/routes/docs/components/index.mdx
nmerget Nov 5, 2024
847caa7
fix: issue with fragments without key
nmerget Nov 5, 2024
1ac674a
Merge remote-tracking branch 'origin/feat-react-fragment-with-key' in…
nmerget Nov 5, 2024
ca1bdd1
chore: update snapshots
nmerget Nov 5, 2024
9dea0e0
Merge branch 'main' into feat-react-fragment-with-key
nmerget Nov 6, 2024
47ca079
chore: update snapshots
nmerget Nov 7, 2024
cacbed9
chore: update snapshots
nmerget Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/long-ghosts-pretend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@builder.io/mitosis': patch
---

[React] Refactor how `react` handles mitosis ``Fragment``.

Using ``import { Fragment } from '@builder.io/mitosis';
`` and `<Fragment key={option}>` in mitosis, generates an empty fragment in ``react`` target: `<>`. With this improvement the generated output will be `<React.Fragment key={`key-${option}`}>`. This will help to avoid issues with same keys e.g. inside for loops.


32 changes: 32 additions & 0 deletions packages/core/src/__tests__/__snapshots__/alpine.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,22 @@ exports[`Alpine.js > jsx > Javascript Test > arrowFunctionInUseStore 1`] = `
"
`;

exports[`Alpine.js > jsx > Javascript Test > basicForFragment 1`] = `
"<div x-data=\\"basicForFragment()\\">
<template x-for=\\"option in ['a', 'b', 'c']\\">
<div x-bind:key=\\"\`key-\${option}\`\\">
<div><span x-html=\\"option\\"></span></div>
</div>
</template>
</div>
<script>
document.addEventListener(\\"alpine:init\\", () => {
Alpine.data(\\"basicForFragment\\", () => ({}));
});
</script>
"
`;

exports[`Alpine.js > jsx > Javascript Test > basicForNoTagReference 1`] = `
"<state.TagNameGetter x-data=\\"myBasicForNoTagRefComponent()\\">
Hello
Expand Down Expand Up @@ -4521,6 +4537,22 @@ exports[`Alpine.js > jsx > Typescript Test > arrowFunctionInUseStore 1`] = `
"
`;

exports[`Alpine.js > jsx > Typescript Test > basicForFragment 1`] = `
"<div x-data=\\"basicForFragment()\\">
<template x-for=\\"option in ['a', 'b', 'c']\\">
<div x-bind:key=\\"\`key-\${option}\`\\">
<div><span x-html=\\"option\\"></span></div>
</div>
</template>
</div>
<script>
document.addEventListener(\\"alpine:init\\", () => {
Alpine.data(\\"basicForFragment\\", () => ({}));
});
</script>
"
`;

exports[`Alpine.js > jsx > Typescript Test > basicForNoTagReference 1`] = `
"<state.TagNameGetter x-data=\\"myBasicForNoTagRefComponent()\\">
Hello
Expand Down
84 changes: 84 additions & 0 deletions packages/core/src/__tests__/__snapshots__/angular.import.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3327,6 +3327,48 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Javascript Test > basicForFragment 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

@Component({
selector: \\"basic-for-fragment\\",
template: \`
<div>
<ng-container
*ngFor=\\"let option of ['a', 'b', 'c']; trackBy: trackByOption0\\"
>
<ng-container>
<div>{{option}}</div>
</ng-container>
</ng-container>
</div>
\`,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class BasicForFragment {
trackByOption0(_, option) {
return \`key-\${option}\`;
}
}

@NgModule({
declarations: [BasicForFragment],
imports: [CommonModule],
exports: [BasicForFragment],
})
export class BasicForFragmentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Javascript Test > basicForNoTagReference 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down Expand Up @@ -10887,6 +10929,48 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Typescript Test > basicForFragment 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

@Component({
selector: \\"basic-for-fragment\\",
template: \`
<div>
<ng-container
*ngFor=\\"let option of ['a', 'b', 'c']; trackBy: trackByOption0\\"
>
<ng-container>
<div>{{option}}</div>
</ng-container>
</ng-container>
</div>
\`,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class BasicForFragment {
trackByOption0(_, option) {
return \`key-\${option}\`;
}
}

@NgModule({
declarations: [BasicForFragment],
imports: [CommonModule],
exports: [BasicForFragment],
})
export class BasicForFragmentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Typescript Test > basicForNoTagReference 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down
86 changes: 86 additions & 0 deletions packages/core/src/__tests__/__snapshots__/angular.mapper.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3372,6 +3372,49 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Javascript Test > basicForFragment 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

@Component({
selector: \\"basic-for-fragment\\",
template: \`
<div>
<ng-container
*ngFor=\\"let option of ['a', 'b', 'c']; trackBy: trackByOption0\\"
>
<ng-container>
<div>{{option}}</div>
</ng-container>
</ng-container>
</div>
\`,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class BasicForFragment {
trackByOption0(_, option) {
return \`key-\${option}\`;
}
}

@NgModule({
declarations: [BasicForFragment],
imports: [CommonModule],
exports: [BasicForFragment],
bootstrap: [SomeOtherComponent],
})
export class BasicForFragmentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Javascript Test > basicForNoTagReference 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down Expand Up @@ -11055,6 +11098,49 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Typescript Test > basicForFragment 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

@Component({
selector: \\"basic-for-fragment\\",
template: \`
<div>
<ng-container
*ngFor=\\"let option of ['a', 'b', 'c']; trackBy: trackByOption0\\"
>
<ng-container>
<div>{{option}}</div>
</ng-container>
</ng-container>
</div>
\`,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class BasicForFragment {
trackByOption0(_, option) {
return \`key-\${option}\`;
}
}

@NgModule({
declarations: [BasicForFragment],
imports: [CommonModule],
exports: [BasicForFragment],
bootstrap: [SomeOtherComponent],
})
export class BasicForFragmentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Typescript Test > basicForNoTagReference 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down
84 changes: 84 additions & 0 deletions packages/core/src/__tests__/__snapshots__/angular.state.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3434,6 +3434,48 @@ export class MyComponentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Javascript Test > basicForFragment 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

@Component({
selector: \\"basic-for-fragment\\",
template: \`
<div>
<ng-container
*ngFor=\\"let option of ['a', 'b', 'c']; trackBy: trackByOption0\\"
>
<ng-container>
<div>{{option}}</div>
</ng-container>
</ng-container>
</div>
\`,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class BasicForFragment {
trackByOption0(_, option) {
return \`key-\${option}\`;
}
}

@NgModule({
declarations: [BasicForFragment],
imports: [CommonModule],
exports: [BasicForFragment],
})
export class BasicForFragmentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Javascript Test > basicForNoTagReference 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down Expand Up @@ -11247,6 +11289,48 @@ export class MyComponentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Typescript Test > basicForFragment 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

@Component({
selector: \\"basic-for-fragment\\",
template: \`
<div>
<ng-container
*ngFor=\\"let option of ['a', 'b', 'c']; trackBy: trackByOption0\\"
>
<ng-container>
<div>{{option}}</div>
</ng-container>
</ng-container>
</div>
\`,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class BasicForFragment {
trackByOption0(_, option) {
return \`key-\${option}\`;
}
}

@NgModule({
declarations: [BasicForFragment],
imports: [CommonModule],
exports: [BasicForFragment],
})
export class BasicForFragmentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Typescript Test > basicForNoTagReference 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down
Loading