fix: identifiers are not incorrectly scoped to state

[liamdebeasi]

Description

https://builder-io.atlassian.net/browse/ENG-7338

Mitosis transforms identifiers that have the same name as state variables to have this. or state. prefixed where necessary. This causes issues with shadowed variables that are unrelated to state.

In the following example, the errors in foo have nothing to do with the errors defined in state.

const state = useStore({
  errors: {},
  foo(errors) {
    return errors;
  }
});

However, this is incorrectly prefixed with state. which causes runtime issues:

const state = useStore({
  errors: {},
  foo(state.errors) {
    return state.errors;
  }
});

This transformation is only needed when moving functions into state or when using useState. To fix this, I updated Mitosis to only transform state values that were set using useState or were function that got moved to state.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

• format the codebase: from the root, run yarn fmt:prettier.
• update all snapshots (in core & CLI): from the root, run yarn test:update
• add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

[changeset-bot]

🦋 Changeset detected

Latest commit: 6a0fc6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@builder.io/mitosis	Patch
@builder.io/mitosis-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6a0fc6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx run-many --target test
• nx e2e @builder.io/e2e-app
• nx run-many --target build --exclude @builder.io/e2e-alpine
• nx build @builder.io/mitosis-site

---

Sent with 💌 from NxCloud.

[samijaber]

can we follow the changeset format here? what exactly got fixed, for which generators/parsers, etc.

[liamdebeasi]

updated in ed6b5f8

Let me know if you have other ideas for how to word this

[samijaber]

[All] Fix: scope renaming of state methods to not include shadow variables
[Angular]: Update state.* -> this.* transform to new AST transform approach