Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made e2e-stencil package private to avoid publishing #1632

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

nmerget
Copy link
Contributor

@nmerget nmerget commented Nov 7, 2024

Description

Please provide the following information:

Add private:true inside package.json for e2e-stencil to avoid publishing.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@nmerget nmerget requested a review from samijaber as a code owner November 7, 2024 07:21
Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 6f9a723

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6f9a723. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@nmerget
Copy link
Contributor Author

nmerget commented Nov 7, 2024

@samijaber I didn't know that private: true has to be set in the e2e packages as well to avoid publishing it. Sorry for that :(

@samijaber samijaber merged commit b1386ef into BuilderIO:main Nov 8, 2024
8 checks passed
@samijaber
Copy link
Contributor

No worries! i missed it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants