Solid: fix Fragment w/ key prop
#1634
Conversation
🦋 Changeset detectedLatest commit: 3b9dbf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3b9dbf2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
| {(option, _index) => { | ||
| const index = _index(); | ||
| return ( | ||
| <Fragment key={\`key-\${option}\`}> |
There was a problem hiding this comment.
@samijaber is Fragment a global component in solid? Found out here that solid fragments are already keyed: solidjs/solid#366 do we need to handle it? or just <>...</> should be sufficient?
There was a problem hiding this comment.
Ah, good catch!
Fragmentis not a global component in solid, or actually a component at all! I don't know why I thought it was- good find on the issue, can keep
<>
fixed in #1639 to ignore all props in Fragments
Description