fix: do not set width binding on Builder Column if value is undefined

[liamdebeasi]

Description

We always create a width binding even if the width is undefined. This causes issues when converting a Mitosis node to JSX as it will yield <Column width={} />. Empty expressions (width={}) are not valid in JSX, so this will crash and JSX parser.

I fixed the issue to only add a width binding when the value is defined.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

• format the codebase: from the root, run yarn fmt:prettier.
• update all snapshots (in core & CLI): from the root, run yarn test:update
• add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

[changeset-bot]

🦋 Changeset detected

Latest commit: d8bc121

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@builder.io/mitosis	Patch
@builder.io/mitosis-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d8bc121. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx e2e @builder.io/e2e-app
• nx run-many --target test
• nx run-many --target build --exclude @builder.io/e2e-alpine
• nx build @builder.io/mitosis-site

---

Sent with 💌 from NxCloud.

[smzelek]

is it possible to move the undefined check to the expression for width inside the bindings?

Suggested change

	...(col.width !== undefined && {
	bindings: {
	width: { code: col.width.toString() },
	},
	}),
	bindings: {
	...(col.width !== undefined && { width: { code: col.width.toString() } }),
	},

[liamdebeasi]

It should be possible, but I think that would result in an empty bindings: {} if the width is defined. I tried to follow the style below that where don't add the properties object if col.link is undefined

[samijaber]

It seems more robust to me that we improve our JSX generator to not print bindings with undefined values, no?

mitosis/packages/core/src/generators/mitosis/generator.ts

Lines 138 to 140 in a76da9d

	for (const key in json.bindings) {
	const value = json.bindings[key]?.code as string;

wouldn't a if (!value) continue in here be enough to handle this universally?

[liamdebeasi]

Sami and I discussed offline, and we need both my change and the one Sami suggested. That has been applied, so I'm going to merge this.