[Rewrite] Implement all existing features #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add: NoResults and Suggestion search events - add: implement SearchContinue action - fix: fix trace_dbg macro (logging)
- add toggle for the toc - implement header jumping for the toc - implement autofocus of the toc
- key 't' will toggle focus of the toc - always show the toc
- remove old static bar - add search status bar - add page status bar
- press 'Enter' to open a selected link - currently, no popup opens, the link is automatically opened (ESC to pop the page and return)
- implement loading of .html pages for debugging - add test-page with link examples
- chore(*): update rust-toolchain to 1.77.2 - chore(tui): update ratatui to 0.26.3 - chore(tui): update tui-input to 0.9 - chore(tui): update tui-logger to 0.11.2 - refactor(tui): remove old link data structures
- fix(wiki-tui): update selection after scrolling - fix(wiki-tui): udpate viewport after changing selection - refactor(wiki-tui): remove code duplication
Fixes the issue of the parser falling back to English when encountering an unknown language by using `Language::Unknown` as a fallback
Implements a popup to change the language of the currently loaded page
Implements a popup to change the language of future searches
The implemented structure passes Actions down to the next component when ignored. First, a received Event or Action is handed to the currently rendered popup (if one exists), and when an ActionResult::Ignored is returned, the Event or Action is handed to either the Search or Page component, depending on the context. This fixes the issue where some Actions would be ignored due to them not being routed to the correct component.
Removes the Help component because it was not needed
Implements and adds the MessagePopupComponent, which displays a message as a dismissable popup
Implements a different kind of popup displaying an error message, for example the search couldn't be executed
Implements a basic yes/no dialog when trying to open a page. Also adds messages for when the link cannot be opened (an external link for example)
Builditluc
added
state: approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues:
In this PR, I aim to reimplement all existing features for wiki-tui.
TODO
F2)F3)