Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented filelist to get list of paths #2598

Closed
wants to merge 1 commit into from

Conversation

eyalk11
Copy link

@eyalk11 eyalk11 commented Aug 25, 2023

Added option to get list of paths. I got into trouble trying to work with list of files in neovim (leaderf or other), when the list of files I wanted to search over was very long. I believe it solves #273 .

See also https://vi.stackexchange.com/questions/42785/how-to-do-fuzzy-live-grep-on-git-files/42915#42915

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but there are numerous issues with this PR as-is. The flag doesn't follow ripgrep's naming convention. Errors are squashed. The documentation for the flag is very insufficient. There are no tests. This also won't handle the case of file paths that contain invalid UTF-8. And perhaps more that I haven't noticed yet.

If you want to try to fix these things that would be great, but this is likely something I'll get to eventually myself if not.

@eyalk11
Copy link
Author

eyalk11 commented Aug 30, 2023

Thanks for the comment. I appreciate it.

It was quick-and-a-bit-dirty patch . I don't really know rust (chatgpt wrote half of it) .
I see what I can do. I can improve documentation and naming, but won't add tests. As it is just too much giving complete lack of knowledge in language, and I am busy as it is.

I feel like in any case it would be better to leave it up to you. But you can let me have a week and will try to get to it.

@eyalk11 eyalk11 marked this pull request as draft August 30, 2023 23:31
@BurntSushi
Copy link
Owner

OK, I'm going to close this out. I think this PR is pretty far from what this should ideally look like. I will very likely tackle this myself at some point.

@BurntSushi BurntSushi closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants