Always show notifications when asleep #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notifications are not displayed when you receive a new message within a chat. If the user would put the device to sleep while viewing a chat then the any notifications received from that chat would be still be suppressed but the device screen would still wake. Now when the device is asleep the notification is always shown.
Addresses the problem where a user would be in a conversation activity and then switch applications and no longer receive notifications from that specific conversation. Should switch to the Google solution of ProcessLifecycleOwner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications are not displayed when you receive a new message within a chat. If the user would put the device to sleep while viewing a chat then the any notifications received from that chat would be still be suppressed but the device screen would still wake.
Now when the device is asleep the notification is always shown.