chore: Remove some redundant calls to typing.cast (meltano#2077)

pyproject.toml

@@ -214,9 +214,10 @@ fail_under = 82
 exclude = "tests"
 files = "singer_sdk"
 python_version = "3.8"
+warn_redundant_casts = true
+warn_return_any = true
 warn_unused_configs = true
 warn_unused_ignores = true
-warn_return_any = true
 
 [[tool.mypy.overrides]]
 ignore_missing_imports = true

singer_sdk/about.py

@@ -138,10 +138,7 @@ def format_about(self, about_info: AboutInfo) -> str:
         Returns:
             A formatted string.
         """
-        max_setting_len = t.cast(
-            int,
-            max(len(k) for k in about_info.settings["properties"]),
-        )
+        max_setting_len = max(len(k) for k in about_info.settings["properties"])
 
         # Set table base for markdown
         table_base = (

singer_sdk/connectors/sql.py

@@ -13,14 +13,14 @@
 
 import simplejson
 import sqlalchemy
-from sqlalchemy.engine import Engine
 
 from singer_sdk import typing as th
 from singer_sdk._singerlib import CatalogEntry, MetadataMapping, Schema
 from singer_sdk.exceptions import ConfigValidationError
 from singer_sdk.helpers.capabilities import TargetLoadMethods
 
 if t.TYPE_CHECKING:
+    from sqlalchemy.engine import Engine
     from sqlalchemy.engine.reflection import Inspector
 
 
@@ -293,7 +293,7 @@ def _dialect(self) -> sqlalchemy.engine.Dialect:
         Returns:
             The dialect object.
         """
-        return t.cast(sqlalchemy.engine.Dialect, self._engine.dialect)
+        return self._engine.dialect
 
     @property
     def _engine(self) -> Engine:
@@ -307,7 +307,7 @@ def _engine(self) -> Engine:
         """
         if not self._cached_engine:
             self._cached_engine = self.create_engine()
-        return t.cast(Engine, self._cached_engine)
+        return self._cached_engine
 
     def create_engine(self) -> Engine:
         """Creates and returns a new engine. Do not call outside of _engine.
@@ -572,10 +572,7 @@ def table_exists(self, full_table_name: str) -> bool:
         """
         _, schema_name, table_name = self.parse_full_table_name(full_table_name)
 
-        return t.cast(
-            bool,
-            sqlalchemy.inspect(self._engine).has_table(table_name, schema_name),
-        )
+        return sqlalchemy.inspect(self._engine).has_table(table_name, schema_name)
 
     def schema_exists(self, schema_name: str) -> bool:
         """Determine if the target database schema already exists.

singer_sdk/helpers/_state.py

@@ -80,7 +80,7 @@ def _find_in_partitions_list(
             f"{{state_partition_context}}.\nMatching state values were: {found!s}"
         )
         raise ValueError(msg)
-    return t.cast(dict, found[0]) if found else None
+    return found[0] if found else None
 
 
 def _create_in_partitions_list(

singer_sdk/streams/sql.py

@@ -51,7 +51,7 @@ def _singer_catalog_entry(self) -> CatalogEntry:
         Returns:
             A CatalogEntry object.
         """
-        return t.cast(CatalogEntry, CatalogEntry.from_dict(self.catalog_entry))
+        return CatalogEntry.from_dict(self.catalog_entry)
 
     @property
     def connector(self) -> SQLConnector: