chore: Feedback for PR 2136

pyproject.toml

@@ -65,6 +65,7 @@ python-dateutil = ">=2.8.2"
 python-dotenv = ">=0.20"
 pytz = ">=2022.2.1"
 PyYAML = ">=6.0"
+rfc3339-validator = ">=0.1.4"
 requests = ">=2.25.1"
 simpleeval = ">=0.9.13"
 simplejson = ">=3.17.6"

singer_sdk/exceptions.py

@@ -146,3 +146,14 @@ class InvalidJSONSchema(Exception):
 
 class InvalidRecord(Exception):
     """Raised when a stream record is invalid according to its declared schema."""
+
+    def __init__(self, error_message: str, record: dict) -> None:
+        """Initialize an InvalidRecord exception.
+
+        Args:
+            error_message: A message describing the error.
+            record: The invalid record.
+        """
+        super().__init__(f"Record Message Validation Error: {error_message}")
+        self.error_message = error_message
+        self.record = record

singer_sdk/sinks/core.py

@@ -97,15 +97,18 @@ def __init__(
                 format_checker = jsonschema_validator.FORMAT_CHECKER
             else:
                 format_checker = format_validators
+
         try:
             jsonschema_validator.check_schema(schema)
-            self.validator = jsonschema_validator(
-                schema=schema, format_checker=format_checker
-            )
         except jsonschema.SchemaError as e:
             error_message = f"Schema Validation Error: {e}"
             raise InvalidJSONSchema(error_message) from e
 
+        self.validator = jsonschema_validator(
+            schema=schema,
+            format_checker=format_checker,
+        )
+
     @override
     def validate(self, record: dict):  # noqa: ANN201
         """Validate a record message.
@@ -119,8 +122,7 @@ def validate(self, record: dict):  # noqa: ANN201
         try:
             self.validator.validate(record)
         except jsonschema.ValidationError as e:
-            error_message = f"Record Message Validation Error: {e.message}"
-            raise InvalidRecord(error_message) from e
+            raise InvalidRecord(e.message, record) from e
 
 
 class Sink(metaclass=abc.ABCMeta):
@@ -443,7 +445,7 @@ def _validate_and_parse(self, record: dict) -> dict:
                 self._validator.validate(record)
             except InvalidRecord as e:
                 if self.fail_on_record_validation_exception:
-                    raise InvalidRecord(e) from e
+                    raise
                 self.logger.exception("Record validation failed %s", e)
 
         self._parse_timestamps_in_record(

tests/core/sinks/test_validation.py

@@ -127,7 +127,7 @@ def test_validate_record_jsonschema_format_checking_enabled_stop_on_error(
     }
     with pytest.raises(
         InvalidRecord,
-        match=r"data.invalid_datetime must be date-time",
+        match=r"Record Message Validation Error",
     ):
         sink._validate_and_parse(record)
 
@@ -170,7 +170,7 @@ def test_validate_record_jsonschema_format_checking_enabled_continue_on_error(
     )
     assert updated_record["missing_datetime"] == "2021-01-01T00:00:00+00:00"
     assert updated_record["invalid_datetime"] == "9999-12-31 23:59:59.999999"
-    assert "data.invalid_datetime must be date-time" in captured.err
+    assert "Record Message Validation Error" in captured.err
 
 
 @pytest.fixture