fix(targets): Quote column names in INSERT statement (meltano#2200)

* Update sql.py * Mattwill09 patch 1 (#1) * Update sql.py * Update test_target_sqlite.py * Update singer_sdk/sinks/sql.py * Use IdentifierPreparer --------- Co-authored-by: Matthew Will <[email protected]>
BuzzCutNorman · Jan 30, 2024 · bfc1bc1 · bfc1bc1
1 parent af3b678
commit bfc1bc1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/singer_sdk/sinks/sql.py b/singer_sdk/sinks/sql.py
@@ -10,6 +10,7 @@
 
 import sqlalchemy as sa
 from pendulum import now
+from sqlalchemy.sql import quoted_name
 from sqlalchemy.sql.expression import bindparam
 
 from singer_sdk.connectors import SQLConnector
@@ -279,10 +280,14 @@ def generate_insert_statement(
             An insert statement.
         """
         property_names = list(self.conform_schema(schema)["properties"].keys())
+        column_identifiers = [
+            self.connector.quote(quoted_name(name, quote=True))
+            for name in property_names
+        ]
         statement = dedent(
             f"""\
             INSERT INTO {full_table_name}
-            ({", ".join(property_names)})
+            ({", ".join(column_identifiers)})
             VALUES ({", ".join([f":{name}" for name in property_names])})
             """,  # noqa: S608
         )

diff --git a/tests/samples/test_target_sqlite.py b/tests/samples/test_target_sqlite.py
@@ -484,14 +484,15 @@ def test_record_with_missing_properties(
                 "properties": {
                     "id": {"type": "integer"},
                     "name": {"type": "string"},
+                    "table": {"type": "string"},
                 },
             },
             [],
             dedent(
                 """\
                 INSERT INTO test_stream
-                (id, name)
-                VALUES (:id, :name)""",
+                (id, name, "table")
+                VALUES (:id, :name, :table)""",
             ),
         ),
     ],