Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing DIK codes to _supportedKeys in XEH_preStart.sqf #1721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Raven3-14
Copy link

Added missing DIK codes to _supportedKeys

When merged this pull request will:

  • Add DIK codes "DIK_F16" through to "DIK_F24" to _supportedKeys, allowing them to be displayed as the correct key in CBA keybindings, rather than "Unknown Key ***"

This will make it match the code in perf/prof branch, and should fix the "Unknown Key ***" for F16~F24 when perf/prof is loaded.
I don't think the vanilla fix has been patched to stable. The relevant ticket in the BI feedback tracker has a note "Fixed in 2.20".

Added missing DIK codes to _supportedKeys
@PabstMirror PabstMirror added this to the 3.18.2 milestone Jan 8, 2025
@PabstMirror PabstMirror modified the milestones: 3.18.2, Ongoing Jan 8, 2025
@PabstMirror
Copy link
Contributor

PabstMirror commented Feb 14, 2025

just noting that we do need to wait for 2.20 or we get

20:08:48 [CBA] (settings) INFO: Finished reading settings from settings file.
20:08:48 Error in expression <EachPair;
} else {
[_hash, {
_namespace setVariable [_key, _value];
}] call CBA_>
20:08:48   Error position: <setVariable [_key, _value];
}] call CBA_>
20:08:48   Error Reserved variable in expression

on non-profiling w/ filepatching

and because this file is compiled to sqfc the macros won't be defined until we update the includes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants