[WIP] Set up a Rust native version of Hardsubx context and rewrite hardsubx.c #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shashwat1002
commented
Oct 31, 2022
shashwat1002
commented
- constructor function (new) made that takes options as argument [this will replace init_hardsubx]
- default function for hardsubx context
- default function for cc_subtitle
- constructor function (new) made that takes options as argument [this will replace init_hardsubx] - default function for hardsubx context - default function for cc_subtitle
|
@PunitLodha please check if the new struct looks okay |
…xt and define AVPacket
shashwat1002
force-pushed
the
struct_rewrite
branch
from
328e45a
to
d32533e
Compare
PunitLodha
force-pushed
the
struct_rewrite
branch
from
de8b351
to
ceeff56
Compare
|
@prateekmedia Since you made the change to |
|
@PunitLodha you can check what the CI says for build_ocr_hardsubx linux, if it runs fine then no change else I think there might be some imports that need to be done. Like ffmpeg_sys_next::* would not be equivalent to rsmpeg::*, some dependencies are needed to be include manually. Check my implementation on mod.rs and utility.rs |
|
@prateekmedia @IshanGrover2004 @PunitLodha thoughts on this PR? |
|
Code looks fine, but it needs testing before it can be merged. @prateekmedia @cfsmp3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.