Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_passed_on and description in regression_test table #853

Merged

Conversation

Tarun-Arora
Copy link
Contributor

@Tarun-Arora Tarun-Arora commented Aug 16, 2023

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

This PR is a step to improve regression test results, by enabling when each regression test was last passed on the master branch
Also adding a description field for regression tests to help developers with the importance of a test

FRONTEND CHECK FOR MAX DESCRIPTION LENGTH
image

Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Thanks for the PR. Please have a look at the suggestions.

templates/ci/pr_comment.txt Outdated Show resolved Hide resolved
migrations/versions/b3ed927671bd_.py Outdated Show resolved Hide resolved
mod_regression/models.py Outdated Show resolved Hide resolved
mod_ci/controllers.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22% 🎉

Comparison is base (d30129e) 85.76% compared to head (7f71832) 85.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   85.76%   85.98%   +0.22%     
==========================================
  Files          35       35              
  Lines        3617     3624       +7     
  Branches      729      729              
==========================================
+ Hits         3102     3116      +14     
+ Misses        378      372       -6     
+ Partials      137      136       -1     
Flag Coverage Δ
unittests 85.98% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mod_ci/controllers.py 81.19% <100.00%> (+0.04%) ⬆️
mod_regression/controllers.py 97.32% <100.00%> (+3.17%) ⬆️
mod_regression/forms.py 100.00% <100.00%> (ø)
mod_regression/models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tarun-Arora Tarun-Arora marked this pull request as ready for review August 20, 2023 07:44
@Tarun-Arora Tarun-Arora changed the title Add last_passed_on in regression_test table Add last_passed_on and description in regression_test table Aug 20, 2023
@Tarun-Arora
Copy link
Contributor Author

This PR is ready to be reviewed, I might need to add some unittests, I'll do that
I'll test PR comments on spdev.ccextractor.org before merging this

Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left two small doubts, please check 🙏🏽

mod_regression/forms.py Outdated Show resolved Hide resolved
templates/ci/pr_comment.txt Outdated Show resolved Hide resolved
@Tarun-Arora Tarun-Arora force-pushed the tarun/add-last-passed-commit branch from 8995973 to 423a095 Compare August 26, 2023 18:09
@Tarun-Arora
Copy link
Contributor Author

This is tested as well now, see comment: CCExtractor/ccextractor#1509 (comment)
and notice line:
ccextractor -svc 1[EUC-KR] -out=txt -noru b5d6aad89f..., Last passed: Test 1

Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thealphadollar thealphadollar merged commit 309c4c2 into CCExtractor:master Aug 27, 2023
11 checks passed
@Tarun-Arora Tarun-Arora deleted the tarun/add-last-passed-commit branch August 28, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants