-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last_passed_on and description in regression_test table #853
Add last_passed_on and description in regression_test table #853
Conversation
Signed-off-by: Tarun Arora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Thanks for the PR. Please have a look at the suggestions.
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #853 +/- ##
==========================================
+ Coverage 85.76% 85.98% +0.22%
==========================================
Files 35 35
Lines 3617 3624 +7
Branches 729 729
==========================================
+ Hits 3102 3116 +14
+ Misses 378 372 -6
+ Partials 137 136 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
This PR is ready to be reviewed, I might need to add some unittests, I'll do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've left two small doubts, please check 🙏🏽
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
8995973
to
423a095
Compare
This is tested as well now, see comment: CCExtractor/ccextractor#1509 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This PR is a step to improve regression test results, by enabling when each regression test was last passed on the master branch
Also adding a description field for regression tests to help developers with the importance of a test
FRONTEND CHECK FOR MAX DESCRIPTION LENGTH