Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Add tags support for samples #858

Merged

Conversation

Tarun-Arora
Copy link
Contributor

@Tarun-Arora Tarun-Arora commented Aug 27, 2023

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

The tags support feature can be divided into the following sub-tasks

  • Create models to support tags
  • Modify frontend to support view of tags for samples as well as regression tests
  • Modify frontend to add a search dropdown and button based on tags
    NOTE: This is in working state but design improvements and implementation is pending
  • Create backend support to query regression tests and samples based on tags
  • Create an "All Categories" option to view all regression tests (This is not supported currently)
  • Make subsequent filter and API calls from frontend to enable queries based on tags
  • Create a way to easily support managing of tags on samples

Core functionality: Filtering regression tests via tags
image

Core functionality: Adding tags on existing samples and creating new tags in a easy way
image

Core functionality: Showing tags on sample info pages
image

Smaller improvements: Showing tags on samples via regression tests and adding an edit button to edit the samples
image

@Tarun-Arora Tarun-Arora deleted the tarun/add-tags-for-samples branch August 28, 2023 08:24
@Tarun-Arora Tarun-Arora restored the tarun/add-tags-for-samples branch August 29, 2023 10:50
@Tarun-Arora Tarun-Arora reopened this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (5f0d048) 86.50% compared to head (bed92d6) 86.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   86.50%   86.62%   +0.12%     
==========================================
  Files          35       35              
  Lines        3645     3678      +33     
  Branches      735      744       +9     
==========================================
+ Hits         3153     3186      +33     
  Misses        354      354              
  Partials      138      138              
Flag Coverage Δ
unittests 86.62% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mod_regression/controllers.py 97.35% <100.00%> (ø)
mod_sample/controllers.py 73.65% <100.00%> (+2.14%) ⬆️
mod_sample/forms.py 100.00% <100.00%> (ø)
mod_sample/models.py 94.04% <100.00%> (+0.89%) ⬆️
mod_upload/forms.py 79.16% <100.00%> (-1.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tarun-Arora Tarun-Arora marked this pull request as ready for review August 31, 2023 07:37
thealphadollar
thealphadollar previously approved these changes Sep 10, 2023
Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in terms of core logic.

I've not gone through the HTML file changes in detail - can you please add screenshots of the pages with the changes highlighted? That would be very helpful.

@Tarun-Arora
Copy link
Contributor Author

LGTM, in terms of core logic.

I've not gone through the HTML file changes in detail - can you please add screenshots of the pages with the changes highlighted? That would be very helpful.

Yes sure, I'll be adding the screenshots of the changes done
Till then, you may refer https://spdev.ccextractor.org/regression for your reference

@thealphadollar thealphadollar merged commit 0a0c07c into CCExtractor:master Sep 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants