-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVEMENT] Add tags support for samples #858
[IMPROVEMENT] Add tags support for samples #858
Conversation
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 86.50% 86.62% +0.12%
==========================================
Files 35 35
Lines 3645 3678 +33
Branches 735 744 +9
==========================================
+ Hits 3153 3186 +33
Misses 354 354
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, in terms of core logic.
I've not gone through the HTML file changes in detail - can you please add screenshots of the pages with the changes highlighted? That would be very helpful.
7dea9cb
to
7c4d2b4
Compare
Yes sure, I'll be adding the screenshots of the changes done |
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
The tags support feature can be divided into the following sub-tasks
NOTE: This is in working state but design improvements and implementation is pending
Core functionality: Filtering regression tests via tags
Core functionality: Adding tags on existing samples and creating new tags in a easy way
Core functionality: Showing tags on sample info pages
Smaller improvements: Showing tags on samples via regression tests and adding an edit button to edit the samples