Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Fix working of draft PRs #868

Merged
merged 5 commits into from
Sep 10, 2023

Conversation

Tarun-Arora
Copy link
Contributor

@Tarun-Arora Tarun-Arora commented Sep 3, 2023

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Closes #865 and this reverts the way draft PRs are being handled introduced in #775

Signed-off-by: Tarun Arora <[email protected]>
Signed-off-by: Tarun Arora <[email protected]>
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.15% 🎉

Comparison is base (cd28d87) 86.03% compared to head (3f8f793) 86.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   86.03%   86.18%   +0.15%     
==========================================
  Files          35       35              
  Lines        3631     3642      +11     
  Branches      731      735       +4     
==========================================
+ Hits         3124     3139      +15     
+ Misses        372      367       -5     
- Partials      135      136       +1     
Flag Coverage Δ
unittests 86.18% <87.50%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mod_ci/controllers.py 81.40% <87.50%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tarun-Arora Tarun-Arora force-pushed the tarun/fix-test-pickups branch from 605d8be to d04c7fe Compare September 3, 2023 21:30
@thealphadollar thealphadollar merged commit 5b4c69c into CCExtractor:master Sep 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Don't run tests if it is from a PR and it is no longer the latest commit of the PR
2 participants