Skip to content

Use absolute import for activity_session_detail #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

winstonsung
Copy link
Contributor

@winstonsung winstonsung commented Aug 6, 2025

This is to prevent class name resolution failed when debugging using different application ID.

Change-Id: Ib752b9f875e4062732787036230fdd590ea5e953

winstonsung added a commit to winstonsung/ccip-android that referenced this pull request Aug 6, 2025
Bug: CCIP-App#118
Change-Id: Ib752b9f875e4062732787036230fdd590ea5e953
winstonsung added a commit to winstonsung/ccip-android that referenced this pull request Aug 6, 2025
Bug: CCIP-App#118
Change-Id: Ib752b9f875e4062732787036230fdd590ea5e953
@winstonsung winstonsung force-pushed the dev-118 branch 2 times, most recently from 7d10cfb to 5d49280 Compare August 6, 2025 07:20
winstonsung added a commit to winstonsung/ccip-android that referenced this pull request Aug 6, 2025
Bug: CCIP-App#118
Change-Id: Ib752b9f875e4062732787036230fdd590ea5e953
winstonsung added a commit to winstonsung/ccip-android that referenced this pull request Aug 6, 2025
Bug: CCIP-App#118
Change-Id: Ib752b9f875e4062732787036230fdd590ea5e953
@winstonsung winstonsung changed the title Unified to use relative namespace in layout XML Use absolute import for activity_session_detail Aug 6, 2025
Bug: CCIP-App#118
Change-Id: Ib752b9f875e4062732787036230fdd590ea5e953
@@ -12,7 +12,7 @@
android:layout_height="@dimen/app_bar_height"
android:fitsSystemWindows="true"
android:theme="@style/AppTheme.AppBarOverlay"
app:layout_behavior=".ui.sessiondetail.ScrollingControlAppBarLayoutBehavior">
app:layout_behavior="app.opass.ccip.ui.sessiondetail.ScrollingControlAppBarLayoutBehavior">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be coming from the material library instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much familiar with Android layout XML. Feel free to create another version of this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants