Add Golden Copy Tests #1674

pluckyswan · 2024-12-23T21:19:08Z

Description

Added golden copy test to RS-E2E tests. It currently is located in the same test class as the automated staging integration test. One submit workflow is responsible for sending all files including assertion and golden copy input. Then, it will fetch the output from Azure and compare them to the expected files based on the run workflow chosen.

TLDR - this utilizes the existing automated staging test submit workflow to send all files and adds a new run workflow specific to golden copy test.

Issue

#1600

Checklist

I have added tests to cover my changes
I have added logging where useful (with appropriate log level)
I have updated the documentation accordingly

Note: You may remove items that are not applicable

Co-Authored-By: Sylvie <[email protected]> Co-Authored-By: Samuel Aquino <[email protected]>

Co-Authored-By: Samuel Aquino <[email protected]> Co-Authored-By: Bella L. Quintero <[email protected]>

Co-authored-by: saquino0827 <[email protected]>

Co-authored-by: saquino0827 <[email protected]> Co-authored-by: Sylvie <[email protected]> Co-authored-by: jcrichlake <[email protected]>

Co-authored-by: jcrichlake <[email protected]>

…structure Co-authored-by: jcrichlake <[email protected]>

Co-authored-by: jcrichlake <[email protected]>

Co-authored-by: jcrichlake <[email protected]> Co-authored-by: James Herr <[email protected]>

Co-authored-by: James Herr <[email protected]> Co-authored-by: jcrichlake <[email protected]>

Co-authored-by: James Herr <[email protected]>

rs-e2e/src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]>

…rmediary into golden-tests

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]> Co-Authored-By: Basilio Bogado <[email protected]>

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Luis Pabon <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]> Co-Authored-By: Basilio Bogado <[email protected]>

Co-Authored-By: Sylvie <[email protected]> Co-Authored-By: James Gilmore <[email protected]>

rs-e2e/src/test/groovy/gov/hhs/cdc/trustedintermediary/rse2e/GoldenCopyTest.groovy

.github/workflows/staging-test-run_reusable.yml

...src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/external/azure/AzureBlobFileFetcher.java

Co-authored-by: Sylvie <[email protected]>

Co-authored-by: Sylvie <[email protected]> Co-authored-by: saquino0827 <[email protected]> Co-authored-by: GilmoreA6 <[email protected]>

Co-authored-by: Sylvie <[email protected]> Co-authored-by: saquino0827 <[email protected]> Co-authored-by: GilmoreA6 <[email protected]> Co-authored-by: basiliskus <[email protected]>

Co-authored-by: saquino0827 <[email protected]> Co-authored-by: basiliskus <[email protected]> Co-authored-by: halprin <[email protected]>

pluckyswan · 2025-01-08T18:01:45Z

.github/workflows/golden-copy-staging-test-run.yml

+name: Golden Copy Staging Test - Run integration tests
+
+on:
+  pull_request:


Once the PR is approved, I will remove pull_request. It is only included because a workflow has to be merged into main to be called/updated.

sonarqubecloud · 2025-01-08T18:34:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

basiliskus · 2025-01-08T23:20:09Z

...src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/external/azure/AzureBlobFileFetcher.java

@@ -51,10 +51,22 @@ public static FileFetcher getInstance() {

    @Override
    public List<HL7FileStream> fetchFiles() {
+        String rse2ELocalInputFilePath = System.getenv("RSE2E_LOCAL_INPUT_FILE_PATH");


I don't think the azure blob fetcher implementation should care about the file fetcher implementation details (like the value for RSE2E_LOCAL_INPUT_FILE_PATH). Also, figuring out if we're using the golden copy or RS integration test with the RSE2E_LOCAL_INPUT_FILE_PATH value won't work because we need to run both but have only one possible value for that envvar. Instead, you could pass a parameter to fetchFiles (for both local and azure implementation), which will determine if we're fetching files/blobs for the golden copy test or the RS integration test

jherrflexion and others added 30 commits December 16, 2024 16:56

WIP Initial setup

07b96d1

add notes for later and initial setup/cleanup

2d14e9a

Added basic compare

f8afd54

Co-Authored-By: Sylvie <[email protected]> Co-Authored-By: Samuel Aquino <[email protected]>

Testing workflow dispatch

dad2cd3

Co-Authored-By: Samuel Aquino <[email protected]> Co-Authored-By: Bella L. Quintero <[email protected]>

Aded Golden tests to gradle

1d8877c

Co-Authored-By: Samuel Aquino <[email protected]> Co-Authored-By: Bella L. Quintero <[email protected]>

Adding Golden tests to Workflows

9b81688

Co-Authored-By: Samuel Aquino <[email protected]> Co-Authored-By: Bella L. Quintero <[email protected]>

Added fetch parameter

d4867f7

Co-Authored-By: Samuel Aquino <[email protected]> Co-Authored-By: Bella L. Quintero <[email protected]>

Removed comments

87dbc14

Co-Authored-By: Samuel Aquino <[email protected]> Co-Authored-By: Bella L. Quintero <[email protected]>

add input files and delete unused input files

5bef9f0

Co-authored-by: saquino0827 <[email protected]>

refactor file fetcher and implementation

83edb87

Co-authored-by: saquino0827 <[email protected]>

refactor file fetcher calls

084387d

add env to workflow and rename file path

1e49731

Co-authored-by: saquino0827 <[email protected]>

modify example files to be aligned with readme reqs

3de1187

move directory up one and fix file paths

ebe7a46

move golden copy to automated to get files after transformed

9605cc1

use correct syntax

f63c56c

Co-authored-by: saquino0827 <[email protected]>

make variables strings

de61fb5

Co-authored-by: saquino0827 <[email protected]>

add dollar sign to echo

96cae6c

Co-authored-by: saquino0827 <[email protected]>

try fixing format

e17f1e9

Co-authored-by: saquino0827 <[email protected]>

change syntax

0747ee8

Co-authored-by: saquino0827 <[email protected]>

remove line break at end of line in example files

bdbed53

Co-authored-by: saquino0827 <[email protected]> Co-authored-by: Sylvie <[email protected]> Co-authored-by: jcrichlake <[email protected]>

add double quotes to if statement

71a243d

Co-authored-by: jcrichlake <[email protected]>

add golden copy versions of example files and revert to og directory …

24e5ac3

…structure Co-authored-by: jcrichlake <[email protected]>

modify msh-10 header in example file

401c50f

Co-authored-by: jcrichlake <[email protected]>

fix syntax

229af63

Co-authored-by: jcrichlake <[email protected]>

remove breaks from example file

9485cda

Co-authored-by: jcrichlake <[email protected]> Co-authored-by: James Herr <[email protected]>

add example file

3c850de

Co-authored-by: James Herr <[email protected]> Co-authored-by: jcrichlake <[email protected]>

remove comment, add quotes to variable, and create workflow file

1f0dde2

Co-authored-by: James Herr <[email protected]>

remove done

d7623ae

Co-authored-by: James Herr <[email protected]>

remove unused workflow

92c039c

Co-authored-by: James Herr <[email protected]>

basiliskus reviewed Dec 27, 2024

View reviewed changes

rs-e2e/src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java Outdated Show resolved Hide resolved

jherrflexion and others added 10 commits December 27, 2024 11:05

Fixed bad character

f5b1220

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]>

Merge branch 'golden-tests' of https://github.com/CDCgov/trusted-inte…

b0da8ac

…rmediary into golden-tests

Updated readme with env variable steps

870cfdb

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]> Co-Authored-By: Basilio Bogado <[email protected]>

Added pull_request to the workflow

4412f6e

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]> Co-Authored-By: Basilio Bogado <[email protected]>

Temp testing

59f0c1a

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]> Co-Authored-By: Basilio Bogado <[email protected]>

Added expected files for testing

8e9b069

Co-Authored-By: Bella L. Quintero <[email protected]> Co-Authored-By: Luis Pabon <[email protected]> Co-Authored-By: Jeremy Rosenfeld <[email protected]> Co-Authored-By: Basilio Bogado <[email protected]>

Pushing to trigger Action

7ba9b0b

Co-Authored-By: Sylvie <[email protected]> Co-Authored-By: James Gilmore <[email protected]>

Troubleshooting validation error

1232ae4

Co-Authored-By: Sylvie <[email protected]> Co-Authored-By: James Gilmore <[email protected]>

Merge branch 'main' into golden-tests

c4b79e9

correct merge conflicts

2943f8f

basiliskus reviewed Jan 3, 2025

View reviewed changes

rs-e2e/src/test/groovy/gov/hhs/cdc/trustedintermediary/rse2e/GoldenCopyTest.groovy Outdated Show resolved Hide resolved

Removed added white space

2e34325

saquino0827 reviewed Jan 3, 2025

View reviewed changes

.github/workflows/staging-test-run_reusable.yml Outdated Show resolved Hide resolved

...src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/external/azure/AzureBlobFileFetcher.java Outdated Show resolved Hide resolved

pluckyswan and others added 9 commits January 7, 2025 12:27

rename file path variable to be specifc to rse2e

5124bdc

rename file path variable in azureblobfetcher

88a11fc

remove trigger on pr

a9c0bc4

add back trigger for pr

ef3d035

modify file path and make error more specific

897e2fd

rename expected files to include expected in file name and add logging

0847dc8

Co-authored-by: Sylvie <[email protected]>

fix expected file and remove debug logs

ef12692

Co-authored-by: Sylvie <[email protected]> Co-authored-by: saquino0827 <[email protected]> Co-authored-by: GilmoreA6 <[email protected]>

cleanup todos

c95c0ad

Co-authored-by: Sylvie <[email protected]> Co-authored-by: saquino0827 <[email protected]> Co-authored-by: GilmoreA6 <[email protected]> Co-authored-by: basiliskus <[email protected]>

combine groovy tests into one file and change workflows to match

72dc7d6

Co-authored-by: saquino0827 <[email protected]> Co-authored-by: basiliskus <[email protected]> Co-authored-by: halprin <[email protected]>

pluckyswan commented Jan 8, 2025

View reviewed changes

pluckyswan added 3 commits January 8, 2025 11:08

Merge branch 'main' into golden-tests

cf22c63

update adr

09baadc

update rs-e2e readme

ed42620

pluckyswan marked this pull request as ready for review January 8, 2025 22:40

basiliskus reviewed Jan 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Golden Copy Tests #1674

Add Golden Copy Tests #1674

pluckyswan commented Dec 23, 2024 •

edited

Loading

pluckyswan Jan 8, 2025

sonarqubecloud bot commented Jan 8, 2025

basiliskus Jan 8, 2025 •

edited

Loading

Add Golden Copy Tests #1674

Are you sure you want to change the base?

Add Golden Copy Tests #1674

Conversation

pluckyswan commented Dec 23, 2024 • edited Loading

Description

Issue

Checklist

pluckyswan Jan 8, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 8, 2025

Quality Gate passed

basiliskus Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

pluckyswan commented Dec 23, 2024 •

edited

Loading

basiliskus Jan 8, 2025 •

edited

Loading