Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix observer render attempt past childless sides #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arbruijn
Copy link
Contributor

No description provided.

@roncli
Copy link
Collaborator

roncli commented Dec 16, 2022

My understanding of C is entry level, but I will ask this anyway. :) Is this check happening in the right spot?

if ( (window_check || !visited[ch]) && ((wid & WID_RENDPAST_FLAG) || (observer && ch >= 0)) ) {

If ch can be less than 0 at this point, then !visited[ch] could potentially fail, even with this check.

@arbruijn
Copy link
Contributor Author

That's right, but window_check is always 1 so I didn't bother to change it. I can add the check for visited as well if you prefer.

@roncli
Copy link
Collaborator

roncli commented Dec 21, 2022

Huh. Those are really weird statements that define window_check and some others... But that's neither here nor there, I would definitely add the check just in case someone somewhere down the line wants window_check to be 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants