-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust - shrink prelude #1653
Merged
Merged
Rust - shrink prelude #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c09551
to
a415e90
Compare
a415e90
to
9a633ca
Compare
f0f09b4
to
4e047dc
Compare
e05f3da
to
2f2912b
Compare
876339d
to
a3bf36a
Compare
Open
a3bf36a
to
31a665d
Compare
31a665d
to
f5fe798
Compare
f5fe798
to
e937c0d
Compare
398850e
to
5dcae8f
Compare
5dcae8f
to
83dd418
Compare
Note: 0b72886 is the commit with the meaningful changes |
83dd418
to
226525c
Compare
226525c
to
e60d507
Compare
Only one clippy issue remaining, and its not one under our control: $ cargo clippy
warning: first doc comment paragraph is too long
--> /home/jeremy/Dev/libCEED/target/debug/build/libceed-sys-fbdae9980ac1442f/out/bindings.rs:78:1
|
78 | / #[doc = " Implementation takes ownership of the pointer and will free using CeedFree...
79 | | #[doc = " The user should not assume that the pointer remains valid after ownership ...
80 | | #[doc = " Note that arrays allocated using C++ operator new or other allocators cann...
81 | | #[doc = " CeedFree() is capable of freeing any memory that can be freed using free()."]
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
help: add an empty line
|
78 ~ #[doc = " Implementation takes ownership of the pointer and will free using CeedFree() when done using it."]
79 + ///
|
warning: `libceed-sys` (lib) generated 1 warning (run `cargo clippy --fix --lib -p libceed-sys` to apply 1 suggestion)
Checking libceed v0.12.0 (/home/jeremy/Dev/libCEED/rust/libceed)
Checking mesh v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/mesh)
Checking ex1-volume v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex1-volume)
Checking ex4-vector-surface v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex4-vector-surface)
Checking ex3-vector-volume v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex3-vector-volume)
Checking ex2-surface v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex2-surface)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.55s |
We can either turn off that lint or insert an empty line after the subject/summary sentence? |
Ah, found where to stick the annotation for the generated bindings. Clippy now runs clean $ cargo clippy
Checking utf8parse v0.2.2
Checking colorchoice v1.0.2
Checking anstyle v1.0.8
Checking anstyle-query v1.1.1
Checking is_terminal_polyfill v1.70.1
Checking strsim v0.11.1
Checking clap_lex v0.7.2
Compiling libceed-sys v0.12.0 (/home/jeremy/Dev/libCEED/rust/libceed-sys)
Checking anstyle-parse v0.2.5
Checking anstream v0.6.15
Checking clap_builder v4.5.15
Checking clap v4.5.16
Checking libceed v0.12.0 (/home/jeremy/Dev/libCEED/rust/libceed)
Checking mesh v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/mesh)
Checking ex4-vector-surface v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex4-vector-surface)
Checking ex1-volume v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex1-volume)
Checking ex2-surface v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex2-surface)
Checking ex3-vector-volume v0.11.0 (/home/jeremy/Dev/libCEED/examples/rust/ex3-vector-volume)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.99s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, dropped a lot of the contents of the prelude, mirroring changes in petsc-rs.
Also made some clippy fixes.
fixes #1599