Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain decomposition #169

Merged
merged 63 commits into from
Mar 19, 2024
Merged

domain decomposition #169

merged 63 commits into from
Mar 19, 2024

Conversation

shac170
Copy link
Contributor

@shac170 shac170 commented Mar 15, 2024

adding domain decomposition

Copy link
Member

@ilhamv ilhamv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shac170, really good work!

Can we merge loop_source_dd into loop_source, such that we always have domain decomposition turned on, but by default, there is only one domain shared by all the processes? Having two separate loops, that very similarly function, would mean having multiple stuff to maintain as the code grows.

test/regression/run.py Show resolved Hide resolved
mcdc/__init__.py Outdated Show resolved Hide resolved
mcdc/card.py Outdated Show resolved Hide resolved
mcdc/card.py Outdated Show resolved Hide resolved
mcdc/type_.py Outdated Show resolved Hide resolved
mcdc/kernel.py Outdated Show resolved Hide resolved
mcdc/kernel.py Outdated Show resolved Hide resolved
mcdc/loop.py Outdated Show resolved Hide resolved
Copy link
Member

@ilhamv ilhamv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After refactoring (merging dd and source loops), running with multiple processes is not reproducible. Let's track that in Issue as planned, @shac170 . Thanks!

@ilhamv ilhamv changed the base branch from main to dev March 19, 2024 15:19
@ilhamv ilhamv merged commit 1bbb316 into CEMeNT-PSAAP:dev Mar 19, 2024
6 checks passed
@shac170 shac170 deleted the good_dd branch March 19, 2024 17:47
@shac170 shac170 restored the good_dd branch January 24, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants