-
Notifications
You must be signed in to change notification settings - Fork 4
[2주차] 함초롬 미션 제출합니다. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chorom-ham
wants to merge
12
commits into
CEOS-Developers:chorom-ham
Choose a base branch
from
chorom-ham:chorom
base: chorom-ham
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b3a3b9c
TodoInput 수정
chorom-ham 8693d70
TodoInput 약간 수정, Todocard 및 Todo 코드 추가
chorom-ham ce1b9f8
todo 수정. index값 증가 안되는 오류 있음.
chorom-ham 17c5fd0
style 추가.. index값 증가 안되는 오류 그대로.
chorom-ham 9a94235
오류 수정
chorom-ham 73e11f9
README 삭제
chorom-ham 40d76a7
피드백 사항 수정
chorom-ham 512309f
Merge branch 'chorom' of https://github.com/chorom-ham/react-todo int…
chorom-ham aa17100
Update README.md
chorom-ham 163f3c8
2차 피드백 반영 수정
chorom-ham 6732b8c
Merge branch 'chorom' of https://github.com/chorom-ham/react-todo int…
chorom-ham d661874
3차 피드백 반영 수정
chorom-ham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,16 @@ | ||
# react-todo | ||
|
||
## 실행 방법 | ||
|
||
``` | ||
npm install | ||
npm run start | ||
``` | ||
|
||
- npm install : 필요한 모든 패키지를 설치합니다. 처음 1번만 실행하면 됩니다. | ||
- npm run start : react 어플리케이션을 브라우저에서 실행합니다. | ||
|
||
## 미션 설명 | ||
|
||
### 프로그램 실행 결과 | ||
|
||
[확인하기](https://react-todo.greatsumini.now.sh/) | ||
|
||
### 프로그래밍 요구 사항 | ||
|
||
1. 제공되지 않은 component 파일은 생성하지 않는다. | ||
2. 모든 스타일링은 styled-components를 이용해서한다. | ||
3. 프로그램 실행결과와 스타일이 같지 않아도 된다. 언뜻 보기에 비슷한 정도로만 따라해보자! | ||
|
||
### 미션 저장소 및 진행 요구 사항 | ||
|
||
- 미션은 이 저장소를 fork/clone해 시작한다. | ||
- clone된 폴더의 README.md의 내용을 모두 지운다. | ||
- 프로그램 실행 결과 페이지를 보고, 만들어야 할 기능들을 README.md에 정리해본다. | ||
- 각 Component별로 props, state를 정리해 추가한다. | ||
- 각 Component 작성을 완료할 때마다 git에 commit한다. | ||
- [스터디 과제제출](https://github.com/CEOS-Developers/react-profile/blob/master/docs/how-to-submit/README.md) 문서를 참고해 미션을 제출한다. | ||
<h2>Todo 컴포넌트</h2> | ||
state로 todoList[] 배열 가지고 있음 | ||
|
||
<h2>TodoCard 컴포넌트</h2> | ||
props: index, text, onClick // Todo에서 해당 정보를 가져온다 | ||
|
||
<h2>TodoInput 컴포넌트</h2> | ||
기본태그 대신 스타일 태그를 사용하자. | ||
폼의 onSubmit 속성으로 this.props.onSubmit(e.target.todo.value)을 사용해 상위 컴포넌트인 Todo컴포넌트의 onSubmit 함수를 호출한다. | ||
|
||
<h2>추가로 알게된 것</h2> | ||
<ul> | ||
<li> 화살표 함수 </li> | ||
<li> map 메서드 </li> | ||
<li> 빈 배열 선언 </li> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md도 작성해주세요 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 넵!