Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSPN][Migration] Beams field values #237

Closed
ntarocco opened this issue Oct 30, 2024 · 6 comments
Closed

[SSPN][Migration] Beams field values #237

ntarocco opened this issue Oct 30, 2024 · 6 comments
Assignees
Milestone

Comments

@ntarocco
Copy link
Contributor

ntarocco commented Oct 30, 2024

Attached the list of values for the field 693__b Beam field.

beams.csv

@PaulinaBaranowska
Copy link
Collaborator

Please assign this to me

@PaulinaBaranowska
Copy link
Collaborator

PaulinaBaranowska commented Nov 7, 2024

These values should be kept, and ideally this should become controlled vocabulary.
Next steps:

  • Clean up values and update them in CDS
  • Reach out to ATS (maybe new SIPB BE representative) if this can be controlled vocabulary (is there a list?)

@PaulinaBaranowska
Copy link
Collaborator

We have cleaned up the values in 693__b that seemed out of place: Beams values_corrected.xlsx
We consulted ATS, and it seems that a list of transfer lines can be extracted from the Layout Database. So the question is, should this be controlled vocabulary? From what we see in #244 it might be planned as a freetext field?

Looking at the current displays you have, perhaps the phrasing under the individual fields should be changed from
"You should fill this field with one of the recognised accelerators" to "Please select a recognised accelerator from the list if applicable" It might prevent people from submitting garbage because they think they need to put something in the field.

@ntarocco
Copy link
Contributor Author

Thank you, we will see how to get the data. Related issue.

@michamos
Copy link
Collaborator

Comment I made on Mattermost:

Paulina was informed about the Layout DB by a user, we don't know who maintains the list of beam lines and if there's an independent source of info. Maybe we could start by simply having a controlled vocabulary that contains the list of values that are currently in use on CDS, then revisit it when we tackle the collections that are more relevant for the EN/BE departments?

@zzacharo
Copy link
Contributor

We have cleaned up the values in 693__b that seemed out of place: Beams values_corrected.xlsx We consulted ATS, and it seems that a list of transfer lines can be extracted from the Layout Database. So the question is, should this be controlled vocabulary? From what we see in #244 it might be planned as a freetext field?

Looking at the current displays you have, perhaps the phrasing under the individual fields should be changed from "You should fill this field with one of the recognised accelerators" to "Please select a recognised accelerator from the list if applicable" It might prevent people from submitting garbage because they think they need to put something in the field.

beams custom field was implemented as a dropdown field autocompleting from the list of curated values. We continue enriching the vocabulary for later collections in #259

@github-project-automation github-project-automation bot moved this from For review to Done in CDS-RDM - Library tasks Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants