assets: fix header + banner placement #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpsherva
commented
Jan 22, 2025
kpsherva
commented
- templates: fix community card link
- closes Featured communities: CSS issues #324
zzacharo
reviewed
Jan 22, 2025
site/cds_rdm/views.py
Outdated
| context = {"featured_communities": featured, "my_communities": my_comms} | ||
|
|
||
| context = {"featured_communities": featured} | ||
| print(context) |
| featured = featured_communities_search.to_dict()["hits"]["hits"] | ||
| if current_user.is_authenticated: |
There was a problem hiding this comment.
it does not matter if the user is authenticated or not, we will get on featured communities, by default the current identity will see only the ones it can see (by permissions) even if it is anonymous. It was not needed at all, so I removed this
kpsherva
force-pushed
the
ui-buxfix
branch
2 times, most recently
from
4df14da to
5c87253
Compare
jrcastro2
reviewed
Jan 22, 2025
* templates: fix community card link * closes CERNDocumentServer#324
jrcastro2
approved these changes
Jan 22, 2025
ntarocco
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.