Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resultList: add extra information #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrcastro2
Copy link
Contributor

@jrcastro2 jrcastro2 commented Jan 30, 2025

@kpsherva
Copy link
Contributor

@ntarocco do you think we could have an icon instead of Accelerators: ? I think there is too much text in one place and it does not help with quickly scanning the content.
I would move the report number on top of the entry - either on the left side or inside a label. I think it is better to have it separately from the text, since it is an identifier. It will also help with text crowding on the bottom

@zzacharo
Copy link
Contributor

@ntarocco do you think we could have an icon instead of Accelerators: ? I think there is too much text in one place and it does not help with quickly scanning the content. I would move the report number on top of the entry - either on the left side or inside a label. I think it is better to have it separately from the text, since it is an identifier. It will also help with text crowding on the bottom

+1 on the report number move. I am not sure about the icons, maybe after the move of the report number text is better? Also. @jrcastro2 from the screenshot do we have so many values at once for accelerator and experiments? Or did you add them as an example?

@ntarocco
Copy link
Contributor

@ntarocco do you think we could have an icon instead of Accelerators: ? I think there is too much text in one place and it does not help with quickly scanning the content.

It is gonna be hard to find a good icon. If you add experiment/accelerator icons, that you can understand without reading, why not.

I would move the report number on top of the entry - either on the left side or inside a label. I think it is better to have it separately from the text, since it is an identifier. It will also help with text crowding on the bottom

You missed our chat on this, IMO, at least for the time being, it should not be much visible. That's the entire objective. This might change in the future.

@jrcastro2
Copy link
Contributor Author

@ntarocco do you think we could have an icon instead of Accelerators: ? I think there is too much text in one place and it does not help with quickly scanning the content. I would move the report number on top of the entry - either on the left side or inside a label. I think it is better to have it separately from the text, since it is an identifier. It will also help with text crowding on the bottom

+1 on the report number move. I am not sure about the icons, maybe after the move of the report number text is better? Also. @jrcastro2 from the screenshot do we have so many values at once for accelerator and experiments? Or did you add them as an example?

Just added them as an example, I would guess most of them would not have so many, but since it accepts multiple value I tried it.

const hasMetaData = cdsReferenceId || accelerators.length > 0 || experiments.length > 0;
const referenceOrAccelerators = cdsReferenceId || accelerators.length > 0;
return (
<div>
Copy link
Contributor

@kpsherva kpsherva Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div>
</>

<div> can be a problem for semantic styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show report numbers (and other fields?) in search results
4 participants