-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resultList: add extra information #341
base: master
Are you sure you want to change the base?
Conversation
jrcastro2
commented
Jan 30, 2025
•
edited
Loading
edited
- closes Show report numbers (and other fields?) in search results #312
- Requires resultList: Add overridable descriptio inveniosoftware/invenio-app-rdm#2971
@ntarocco do you think we could have an icon instead of |
+1 on the report number move. I am not sure about the icons, maybe after the move of the report number text is better? Also. @jrcastro2 from the screenshot do we have so many values at once for accelerator and experiments? Or did you add them as an example? |
It is gonna be hard to find a good icon. If you add experiment/accelerator icons, that you can understand without reading, why not.
You missed our chat on this, IMO, at least for the time being, it should not be much visible. That's the entire objective. This might change in the future. |
Just added them as an example, I would guess most of them would not have so many, but since it accepts multiple value I tried it. |
const hasMetaData = cdsReferenceId || accelerators.length > 0 || experiments.length > 0; | ||
const referenceOrAccelerators = cdsReferenceId || accelerators.length > 0; | ||
return ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div> | |
</> |
<div>
can be a problem for semantic styles