Aos 2 traits concept efif

[efifogel]

Summary of Changes

This PR does not change the code (except perhaps some negligible changes, such as adding or removing spaces or editing comments).

1. Renamed the prefix of the names of all concepts in the Arrangement_on_surface_2 package from "Arrangement" to "Aos". This slightly affects packages other than the Aos_2 package.
2. Introduced a new concept called AosApproximateTraits_2. It refines the concept AosApproximatePointTraits_2. This concept requires the provision of a functor called Approximate_2. In addition to an operator that approximates the coordinates of a point, it also requires the provision of (i) an operator that approximates a points, and (ii) an operator that approximates a curve.
3. Changed all "typedef" style statements in the user manual to "using" style. (Observe that a similar update to the examples has already been made in a previous release.)

Release Management

• Affected package(s): Arrangement_on_surface_2
• Issue(s) solved (if any): NA
• Feature/Small Feature: Features/Small Features/Aos2 Approximation Concept
• Link to compiled documentation: 2D Arrangement On Surface
• License and copyright ownership: TAU

[albert-github]

I don't think the \cgalConcept is intended here, as this is an ALIASES with content:

cgalConcept=\details <div id=\"CGALConcept\"></div>^^ \brief"

resulting in:

/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'details' for the command '@ingroup', ignoring command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'div' for the command '@ingroup', ignoring command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'id' for the command '@ingroup', ignoring command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'CGALConcept' for the command '@ingroup', ignoring command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'div' for the command '@ingroup', ignoring command

during the overnight doxygen build https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.1-Ic-96/logs_master/Arrangement_on_surface_2.log

Either the \cgalConcept:

• should be removed here
• should be on a separate line.

[efifogel]

Good catch. Fixed it. Thanks. ____ _ ____ _ /_____/_) o /__________ __ // (____ ( ( ( (_/ (_/-(-'_(/ _/

…

On Tue, 25 Feb 2025 at 11:59, albert-github ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h <#8713 (comment)>: > @@ -0,0 +1,77 @@ +/*! \ingroup PkgArrangementOnSurface2ConceptsTraits \cgalConcept I don't think the \cgalConcept is intended here, as this is an ALIASES with content: cgalConcept=\details <div id=\"CGALConcept\"></div>^^ \brief" resulting in: /home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'details' for the command ***@***.***', ignoring command /home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'div' for the command ***@***.***', ignoring command /home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'id' for the command ***@***.***', ignoring command /home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'CGALConcept' for the command ***@***.***', ignoring command /home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-96/doc/Arrangement_on_surface_2/Concepts/AosTraits_2.h:51: warning: Found non-existing group 'div' for the command ***@***.***', ignoring command during the overnight doxygen build https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.1-Ic-96/logs_master/Arrangement_on_surface_2.log Either the `\cgalConcept: - should be removed here - should be on a separate line. — Reply to this email directly, view it on GitHub <#8713 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBNOGFHLAAEPHEKX24YZL2RQ5HXAVCNFSM6AAAAABVXWZYKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBQGQYTQMRUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>