Skip to content

Commit

Permalink
fix: fixing linting action and lint errors [2024-11-26]
Browse files Browse the repository at this point in the history
  • Loading branch information
CHRISCARLON committed Nov 26, 2024
1 parent 3b2d405 commit f4bec6b
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/herding_cats_linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,10 @@ jobs:
python -m pip install --upgrade pip
pip install ruff
- name: Create Ruff config
run: |
echo "[tool.ruff]" > pyproject.toml
echo "ignore = [\"F841\"]" >> pyproject.toml
- name: Run Ruff linting
run: ruff check .
1 change: 1 addition & 0 deletions HerdingCats/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"CkanDataCatalogues",
"OpenDataSoftDataCatalogues",
"OpenDataSoftCatExplorer",
"CkanApiPathsDocs"
]

__version__ = "0.1.4"
2 changes: 0 additions & 2 deletions HerdingCats/explorer/cat_explore.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,6 @@ def package_list_dataframe_extra(
response = self.cat_session.session.get(url)
response.raise_for_status()
data = response.json()
result = data["result"]
data = response.json()
dictionary_prep = data["result"]
dictionary_data = [
{
Expand Down
1 change: 0 additions & 1 deletion tests/ckan/test_ ckan_package_count.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import pytest
from HerdingCats.session.cat_session import CatSession
from HerdingCats.explorer.cat_explore import CkanCatExplorer
from HerdingCats.endpoints.api_endpoints import CkanApiPaths
import requests
from loguru import logger

Expand Down
1 change: 0 additions & 1 deletion tests/ckan/test_ckan_extract_resource.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import pytest
from HerdingCats.session.cat_session import CatSession
from HerdingCats.explorer.cat_explore import CkanCatExplorer
from HerdingCats.errors.cats_errors import CatExplorerError
from loguru import logger

CATALOGUES = ["https://data.london.gov.uk"]
Expand Down
1 change: 0 additions & 1 deletion tests/ckan/test_ckan_package_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from pprint import pprint
from HerdingCats.session.cat_session import CatSession
from HerdingCats.explorer.cat_explore import CkanCatExplorer
from HerdingCats.errors.cats_errors import CatExplorerError
from loguru import logger

CATALOGUES = ["https://data.london.gov.uk"]
Expand Down
1 change: 0 additions & 1 deletion tests/ckan/test_ckan_show_package_info.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import pytest
from HerdingCats.session.cat_session import CatSession
from HerdingCats.explorer.cat_explore import CkanCatExplorer
from HerdingCats.errors.cats_errors import CatExplorerError
import requests
from loguru import logger

Expand Down

0 comments on commit f4bec6b

Please sign in to comment.