Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement INL and timewalk correction in HGCAL TOA kernel #163

Open
wants to merge 1 commit into
base: CMSSW_15_0_0_pre2
Choose a base branch
from

Conversation

stahlleiton
Copy link

PR description:

This PR implements the ToA INL and timewalk correction in the HGCAL ToA kerner.

@stahlleiton stahlleiton requested a review from pfs January 22, 2025 14:12
@pfs pfs requested a review from IzaakWN January 22, 2025 16:07
@pfs
Copy link

pfs commented Jan 23, 2025

Hi thanks a lot! this looks fine to get started but I'm adding Beatriz, Fabio, Chiara

@pfs pfs requested review from camendola and fabio-mon January 23, 2025 08:54
@fabio-mon
Copy link

Thanks for keeping me in the loop. I discussed about it with @stahlleiton a few days ago and it looks fine to me.

Just one NLO question: how do we handle the cases where the fit to extract the tw correction fails? I could in principle dump in the json the fit status

@stahlleiton
Copy link
Author

Thanks for keeping me in the loop. I discussed about it with @stahlleiton a few days ago and it looks fine to me.

Just one NLO question: how do we handle the cases where the fit to extract the tw correction fails? I could in principle dump in the json the fit status

Since when the energy < p2 the correction is ignored, then the simplest would be to set p2 to some very large value when the fit fails

@pfs
Copy link

pfs commented Jan 23, 2025

Thanks for keeping me in the loop. I discussed about it with @stahlleiton a few days ago and it looks fine to me.
Just one NLO question: how do we handle the cases where the fit to extract the tw correction fails? I could in principle dump in the json the fit status

Since when the energy < p2 the correction is ignored, then the simplest would be to set p2 to some very large value when the fit fails

Can work. Otherwise you can have (as done for the energy) as isToAValid flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants