-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AB2D-5916] AWS Cloud Dependency Upgrade #1312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadibhatla
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super clean, thanks for creating a different branch
61b6bd7
to
bc8fc1e
Compare
f1ad116
to
e4bc35b
Compare
fe4f0bb
to
6ec8cfe
Compare
4 tasks
a97bdff
to
429c2b6
Compare
Sadibhatla
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit 32d6d78.
Sadibhatla
added a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-5916
🛠 Changes
WIP - Still might need some cleanup
Remove dependency on org.springframework.cloud
Update Spring AWS Cloud dependency from 2.2.6 to 2.4.4 by migrating to io.awspring.cloud.
Update AB2D Libs versions
ℹ️ Context for reviewers
This is required to potentially use IMDSV2 to fix EC2 issues.
✅ Acceptance Validation
Built locally, to be deployed and tested on IMPL environment
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.