6007 and 6017 #1319
Merged
6007 and 6017 #1319
+65
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smirnovaae
approved these changes
Mar 14, 2024
common/src/main/resources/db/changelog/v2024/misc_opt_out_attribution.sql
Show resolved
Hide resolved
| @@ -167,3 +167,5 @@ databaseChangeLog: | |||
| # file: db/changelog/v2023/create_pg_cron_extension.sql | |||
| - include: | |||
| file: db/changelog/v2024/create_current_mbi_procedure.sql | |||
| - include: | |||
There was a problem hiding this comment.
nit: I don't see deleting existing procedures
There was a problem hiding this comment.
Drop procs are there as part of misc sql file itself at the end
There was a problem hiding this comment.
Drop procs are there as part of misc sql file itself at the end
ah! missed it. wonderful!
4 tasks
smirnovaae
reviewed
Mar 21, 2024
| FROM job_view | ||
| WHERE contract_number not LIKE 'Z%' | ||
| ) and effective_date> CURRENT_DATE - 1 | ||
| on conflict do nothing |
There was a problem hiding this comment.
please add ; in the end
and then
end; $$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6007
https://jira.cms.gov/browse/AB2D-6017
🛠 Changes
Changed default values from boolean to Null
Updated opt_out_flag to look for everything else than "False" i.e. true or null
Updated 2024 proc to remove sandbox partition
Removed 2023 proc
Added new columns to current_mbi table
Created a new simple view to have mbi as a column and retriving partitions from 2020-23 data from there
ℹ️ Context for reviewers
(Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.)
✅ Acceptance Validation
(How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable.)
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.