Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLP Integration notebook review #120

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Conversation

kmh4321
Copy link
Collaborator

@kmh4321 kmh4321 commented Sep 11, 2020

This PR addresses #108

  • Review notebook for clarity and beginner friendliness
  • Create a table of contents
  • Review for Watson Studio/ Google Colab

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@kmh4321 kmh4321 changed the title [WIP] NLP Integration notebook review NLP Integration notebook review Sep 25, 2020
@kmh4321
Copy link
Collaborator Author

kmh4321 commented Sep 25, 2020

@frreiss my changes are now done. I am yet to verify on Watson Studio but with #128 fix in, it should work smoothly. I can verify once the changes done in #128 are pushed to PyPi.

@kmh4321
Copy link
Collaborator Author

kmh4321 commented Sep 25, 2020

Out of the 31 merge conflicts shown above, only 2 are actual conflicts. Rest are Jupyter metadata related.

@frreiss
Copy link
Member

frreiss commented Sep 28, 2020

Notebook changes look great! I've fixed the merge conflicts using vscode. Waiting on CI to complete.

@frreiss frreiss merged commit 73bedd8 into CODAIT:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants