dlt: fix warning in source and prepare for v2.19.x #732
+590
−831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2025
| @@ -14,13 +14,10 @@ | |||
| ####### | |||
|
|
|||
| # Set minimum Cmake version and setup policy behavior | |||
| cmake_minimum_required(VERSION 3.3) | |||
| cmake_minimum_required(VERSION 3.10) | |||
There was a problem hiding this comment.
Note for beta release
|
Example for truncate technique, any better idea? |
minminlittleshrimp
force-pushed
the
dlt_devel_v2.19.beta
branch
2 times, most recently
from
4294a38 to
45ca61d
Compare
|
Hello @Le-Tin @Bichdao021195 Utests also need reworking, anyone takes responsibility?
Thanks |
This refactoring work is a preparation for v2.19.x + Replace strncpy and strncat with snprintf + Increase integrity by bounding and checking + Handle strings for file names and paths as null-terminated strings. + Git workflow: upload-artifact v3 -> v4 + Utests disabled, will be handled in next commits Signed-off-by: minminlittleshrimp <[email protected]>
minminlittleshrimp
force-pushed
the
dlt_devel_v2.19.beta
branch
from
45ca61d to
f91cb9b
Compare
|
Conf: |
|
Build: |
minminlittleshrimp
changed the title
minminlittleshrimp
force-pushed
the
dlt_devel_v2.19.beta
branch
3 times, most recently
from
42b9dec to
f91cb9b
Compare
| @@ -26,7 +26,7 @@ endif() | |||
|
|
|||
| foreach(TARGET IN LISTS TARGET_LIST) | |||
| set(TARGET_SRCS ${TARGET}) | |||
There was a problem hiding this comment.
Hi @minminlittleshrimp
It is better to " set(TARGET_SRCS ${TARGET}.c)" instead of modifying add_execute.
Thanks
lti9hc
reviewed
Mar 4, 2025
| @@ -42,7 +42,7 @@ if(NOT WITH_DLT_CONSOLE_WO_SBTM) | |||
| endif() | |||
|
|
|||
| foreach(target IN LISTS TARGET_LIST) | |||
| set(target_SRCS ${target}) | |||
| set(target_SRCS ${target}.c) | |||
There was a problem hiding this comment.
if you would like to specify .c for each target_SRCS , I propose to add in TARGET_LIST like that "ist(APPEND TARGET_LIST dlt-receive.c), it will be easy for maintenance
There was a problem hiding this comment.
Hello a Tin,
This document mentions about what we need:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring work is a preparation for v2.19.x