Skip to content

Refactored constraints #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianschneider94
Copy link

Refactored solver.py for better readability/maintainability.

@adam-urbanczyk
Copy link
Member

I might be biased, but it is better to discuss PRs with 1K lines of diff before implementing.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 85.37234% with 55 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (8c68faa) to head (ba236a8).

Files with missing lines Patch % Lines
cadquery/occ_impl/solver.py 84.82% 28 Missing and 23 partials ⚠️
cadquery/assembly.py 89.74% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
- Coverage   95.54%   95.11%   -0.44%     
==========================================
  Files          28       28              
  Lines        7319     7531     +212     
  Branches     1102     1126      +24     
==========================================
+ Hits         6993     7163     +170     
- Misses        195      216      +21     
- Partials      131      152      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adrianschneider94
Copy link
Author

I might be biased, but it is better to discuss PRs with 1K lines of diff before implementing.

Yes, probably 😄
I originally just wanted to add an UndirectedAxis constraint - but wanted to try out, how far Claude could carry a larger refactor - so I got going.
Just see if/what you like, functionally there is no change. The different constraints are just structured into classes so that everything belonging to one constraint is in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants