Add PHP script for extensions and skins setup #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedmaka
reviewed
May 4, 2024
Dockerfile
Outdated
| @@ -103,30 +103,17 @@ RUN set -x; \ | |||
| # Skins | |||
| # The Minerva Neue, MonoBook, Timeless, Vector and Vector 2022 skins are bundled into MediaWiki and do not need to be | |||
| # separately installed. | |||
| COPY _sources/scripts/extensions-skins.sh /tmp/extensions-skins.sh | |||
| COPY _sources/patches/* /tmp/ | |||
| RUN wget -qO /usr/local/bin/yq https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 | |||
There was a problem hiding this comment.
this should have a conditional load for arm64 or amd64 based on arch, otherwise linux/arm64 build of the image could be broken
naresh-kumar-babu
changed the title
yaronkoren
approved these changes
May 12, 2024
yaronkoren
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401 (Issue became obsolete since we're switching to PHP)
It is much easier to do parsing of YAML in PHP than in .sh; the standard way to do YAML parsing in a shell script is to call yq, but yq requires different executables for different architectures. Given that the YAML parsing is already in PHP, it seemed easier to do the whole thing in PHP rather than split the work between two scripts.