Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Random is cached #400

Merged
merged 1 commit into from
May 6, 2024
Merged

Special:Random is cached #400

merged 1 commit into from
May 6, 2024

Conversation

hexmode
Copy link
Contributor

@hexmode hexmode commented May 5, 2024

Describe the bug

Summary: The redirect sent by Special:Random is cached

Description: Visiting Special:Random initially provides a random page. Subsequent visits to the page result in the same redirect. Adding a param (e.g., ?t=5) directs you to a new page but subsequent visits to Special:Random?t=5 end up on the same page.

Expected behavior

A new page every time Special:Random is visited.

@hexmode hexmode added the bug Something isn't working label May 4, 2024
@jeffw16
Copy link
Member

jeffw16 commented May 4, 2024

Uh oh... seems like Varnish is over eager?

@cicalese
Copy link
Contributor

cicalese commented May 4, 2024

Maybe some of the discussion on #252 is relevant?

Copy link

github-actions bot commented May 5, 2024

🐳 The image based on 98fd5493 commit has been built with 1.39.7-20240505-400 tag as ghcr.io/canastawiki/canasta:1.39.7-20240505-400

@hexmode
Copy link
Contributor Author

hexmode commented May 5, 2024

#252 is not relevant since this is just varnish caching results instead of a need to purge the cache when pages are updated (h/t @osnard).

@hexmode hexmode merged commit d0f8559 into master May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants