-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cursor implementation + HW accel #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- account for monitor bounds properly on macos - error early when attempting hardware decoding - fix updater bundle publishing
…/Cap into windows-cursor-stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve functionality, enhance logging, and update configurations. The most important changes include enhancements to logging, updates to the Tauri configuration, and improvements to the ffmpeg hardware device handling.
Enhancements to Logging:
crates/media/src/encoders/h264.rs
: Added detailed logging for frame conversion and error handling in theH264Encoder
class. [1] [2] [3] [4]crates/media/src/encoders/mp4.rs
: Replacedprintln
statements withtracing::info
and added error logging for writing the MP4 trailer.crates/media/src/feeds/camera.rs
: Added debug logging for pixel format selection based on the platform in therun_camera_feed
andbuffer_to_ffvideo
functions. [1] [2] [3]Tauri Configuration Updates:
apps/desktop/src-tauri/tauri.conf.json
: EnabledcreateUpdaterArtifacts
for the bundle configuration.apps/desktop/src-tauri/tauri.prod.conf.json
: Removed thecreateUpdaterArtifacts
setting from the production configuration.apps/desktop/src-tauri/tauri.windows.conf.json
: Added Windows-specific bundle configuration withwix
version set to0.3.26
.Improvements to ffmpeg Hardware Device Handling:
crates/ffmpeg-hw-device/src/lib.rs
: Simplified thetry_use_hw_device
method and added a newCodecExt
trait to iterate over hardware configurations. [1] [2] [3]JavaScript and TypeScript Changes:
apps/desktop/scripts/prepare.js
: Updated thesemverToWIXCompatibleVersion
function to fix a template string issue and added resources to thecreateTauriPlatformConfigs
function. [1] [2]apps/desktop/src/routes/(window-chrome)/(main).tsx
: AddedavailableMonitors
import from@tauri-apps/api/window
.Miscellaneous Changes:
.cargo/config.toml
: Removed theFFMPEG_DIR
environment variable configuration.crates/flags/src/lib.rs
: Setrecord_mouse_state
to be enabled in debug mode.crates/media/src/platform/macos.rs
: Added a function to get the primary monitor bounds.crates/media/src/platform/win.rs
: Addedtracing::debug
import for Windows platform-specific code.