Some helpful improvements

[neoFuzz]

Working on the idea that jitpack.io could be used to help out with working with dependencies. I created this PR with the following changes:

1. Changed the workflow to generate the package files and upload them to the latest release. I believe this ties in with the build process downloading the package.
2. Changed the groupId and bumped up the version. This is to avoid potential conflicts.
3. Removed <scope>test</scope> from the pom.xml - not sure if this is helpful in anyway.
4. Fixed some JavaDoc.

Other changes to the Forge project are required to use this new package. Things like updating actions and workflows to use a new package.

I made some changes to forge-gui-android/pom.xml which seems to work locally:

1. Adding jitpack.io as a plugin repo.

    <pluginRepositories>
        <pluginRepository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </pluginRepository>
    </pluginRepositories>

2. Changing the groupId fromcom.simpligility.maven.plugins to com.github.Card-Forge
3. Bumping the version up to 4.6.3

This needs to be merged and working before jitpack.io will pick it up as a usable plugin.

[Hanmac]

3. Removed <scope>test</scope> from the pom.xml - not sure if this is helpful in anyway.

The test scope is for this library

We don't need the mock dependency from it

[neoFuzz]

My comment is broad. It should have removed the test phase bindings. If it actually did anything at all.

[Hanmac]

My comment is broad. It should have removed the test phase bindings. If it actually did anything at all.

No I mean the test scope are needed for this dependencies

[neoFuzz]

I think I get what you mean. Correct me if I'm wrong.

The dependencies' tests still run when compiling and packaging. It looks like this package needed to avoid tests since that blows up with all kind of errors with no real fix for those errors.

Running mvn -B clean install -DskipTests -Dmaven.test.skip=true -e should work without running into problems and generate the packages for use (and store them locally etc.)

[Hanmac]

Yeah,using would say just keep the test scope for this MR

[neoFuzz]

For completeness, roll back the changes removing <scope>test</scope> ?

[Hanmac]

For completeness, roll back the changes removing <scope>test</scope> ?

Yeah I think so

[neoFuzz]

New commit to revert the test change. Any more thoughts?

[neoFuzz]

I should also note that the GitHub Action should build a release that can be downloaded. It triggers when a new Release is created. Just released I did write in the OP😅

@Hanmac is this good to merge?

[Hanmac]

@kevlahnota i don't know much about the maven plugin, can you look at this too?

[kevlahnota]

@kevlahnota i don't know much about the maven plugin, can you look at this too?

I think this just simplifies things so it's easier to grab the modded artifact though the main project will need update to get the new artifact from jitpack

[Hanmac]

i think that might be good enough for now?

[neoFuzz]

I just tried running it on the computers I use:

1. Home computer: Windows 10 = Builds APK. The only issue was that if the directory wasn't clean, some error occurred.
2. Work computer: Windows 11 = Builds APK, if certain restrictions aren't in effect. The problem I had was uapksigner can't run from a my user's temp folder (work restriction).

Changes don't affect *nix as they don't have cmd.exe and will use continue to bash shell.