chore(lint): upgrade angular-cli to beta25.5 and lint project

CarreraPHP · Jan 13, 2017 · a287dc8 · a287dc8
1 parent e8d23b1
commit a287dc8
Show file tree

Hide file tree

Showing 12 changed files with 152 additions and 156 deletions.
diff --git a/web/README.md b/web/README.md
@@ -1,6 +1,6 @@
 # ScaffoldingAll
 
-This project was generated with [angular-cli](https://github.com/angular/angular-cli) version 1.0.0-beta.24.
+This project was generated with [angular-cli](https://github.com/angular/angular-cli) version 1.0.0-beta.25.5.
 
 ## Development server
 Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.
@@ -22,9 +22,9 @@ Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.
 Run `ng e2e` to execute the end-to-end tests via [Protractor](http://www.protractortest.org/).
 Before running the tests make sure you are serving the app via `ng serve`.
 
-## Deploying to Github Pages
+## Deploying to GitHub Pages
 
-Run `ng github-pages:deploy` to deploy to Github Pages.
+Run `ng github-pages:deploy` to deploy to GitHub Pages.
 
 ## Further help
 

diff --git a/web/package.json b/web/package.json
@@ -6,10 +6,15 @@
   "scripts": {
     "ng": "ng",
     "start": "ng serve",
-    "lint": "tslint \"src/**/*.ts\"",
+    "lint": "tslint \"src/**/*.ts\" --project src/tsconfig.json --type-check && tslint \"e2e/**/*.ts\" --project e2e/tsconfig.json --type-check",
     "test": "ng test",
     "pree2e": "webdriver-manager update --standalone false --gecko false",
-    "e2e": "protractor"
+    "e2e": "protractor",
+    "prefirebase:init": "firebase init",
+    "firebase:init": "firebase init",
+    "postfirebase:init": "firebase init",
+    "prefirebase:deploy": "echo \"run firebase:init if deploy fails\" && ng build --prod",
+    "firebase:deploy": "firebase deploy"
   },
   "private": true,
   "dependencies": {
@@ -39,7 +44,7 @@
     "@types/jasmine": "2.5.38",
     "@types/json5": "0.0.29",
     "@types/node": "^6.0.42",
-    "angular-cli": "1.0.0-beta.24",
+    "angular-cli": "1.0.0-beta.25.5",
     "codelyzer": "~2.0.0-beta.1",
     "jasmine-core": "2.5.2",
     "jasmine-spec-reporter": "2.5.0",
@@ -50,7 +55,7 @@
     "karma-remap-istanbul": "^0.2.1",
     "protractor": "~4.0.13",
     "ts-node": "1.2.1",
-    "tslint": "^4.0.2",
+    "tslint": "^4.3.0",
     "typescript": "~2.0.3"
   }
 }
diff --git a/web/src/app/app.component.spec.ts b/web/src/app/app.component.spec.ts
@@ -14,21 +14,21 @@ describe('AppComponent', () => {
   });
 
   it('should create the app', async(() => {
-    let fixture = TestBed.createComponent(AppComponent);
-    let app = fixture.debugElement.componentInstance;
+    const fixture = TestBed.createComponent(AppComponent);
+    const app = fixture.debugElement.componentInstance;
     expect(app).toBeTruthy();
   }));
 
   it(`should have as title 'app works!'`, async(() => {
-    let fixture = TestBed.createComponent(AppComponent);
-    let app = fixture.debugElement.componentInstance;
+    const fixture = TestBed.createComponent(AppComponent);
+    const app = fixture.debugElement.componentInstance;
     expect(app.title).toEqual('app works!');
   }));
 
   it('should render title in a h1 tag', async(() => {
-    let fixture = TestBed.createComponent(AppComponent);
+    const fixture = TestBed.createComponent(AppComponent);
     fixture.detectChanges();
-    let compiled = fixture.debugElement.nativeElement;
+    const compiled = fixture.debugElement.nativeElement;
     expect(compiled.querySelector('h1').textContent).toContain('app works!');
   }));
 });
diff --git a/web/src/app/app.component.ts b/web/src/app/app.component.ts
@@ -6,5 +6,4 @@ import {Component} from '@angular/core';
   styleUrls: ['./app.component.scss']
 })
 export class AppComponent {
-
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,5 +6,4 @@ import {Component} from '@angular/core'; @@
       styleUrls: ['./app.component.scss']
     })
     export class AppComponent {
     }